-
Notifications
You must be signed in to change notification settings - Fork 66
Added new parameter: --adobe-users all|mapped|group #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new parameter: --adobe-users all|mapped|group #368
Conversation
I'll review this once 2.3 is shipped |
@bhunut-adobe please add a corresponding issue so we can track this feature |
ed5ce7d
to
769ef47
Compare
Totally digging this feature! I have a client for whom I may utilize it for because they have a widely distributed system. One thing I'm noticing playing with it is that if I am using users mapped and adobe users mapped, and I remove a user from the mapped AD group, they are correctly removed from the adobe group. However, when re-adding that user to the AD group, the message states that they are being created as a new user on the console side because they are not in view of the tool when it pulls the user list. BUT, despite the message, it still works - the user is not actually recreated, but they are mapped to the group again. I think this is expected behavior since the tool is doing exactly what it should given the context - but maybe we can make a note about this in the doc somewhere? |
@bhunut-adobe can you please add some documentation about this in usage scenarios and an entry for the new command-line option in command parameters? We'll also need something about it in the revised invocation_defaults section, but I still need to work on that. In the meantime, I will test & review the code. |
I just added the documentation. |
@bhunut-adobe Will you please rebase this against v2 and resolve the merge conflicts? Be sure to force push your rebased branch back your remote fork ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I've made some notes about a few things that might need to be tweaked. This branch also needs to be rebased against v2 (see my note about that). I'll do some testing and let you know if anything else comes up.
@bhunut-adobe I'd like to get this wrapped up soon so we can include it in the 2.4 release. Let me know if you have any questions about the comments I've made. It also still needs to be rebased against v2 so we can make sure these changes will work with those that have been pushed to v2 since this PR was created. Let me know if you have any questions on the rebase process. |
c21151b
to
a54a6eb
Compare
3b23e36
to
42e551f
Compare
303e636
to
31a3a01
Compare
This feature allow UST to pull in All Adobe Users or Only the adobe groups specified in User-Sync-Config.yml or a list of group.
Example:
--adobe-users mapped
--adobe-users all
--adobe-users group "GroupA,GroupB,GroupC"