Skip to content

Additional group sync updates #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 27, 2018
Merged

Additional group sync updates #405

merged 14 commits into from
Nov 27, 2018

Conversation

adorton-adobe
Copy link
Collaborator

@adorton-adobe adorton-adobe commented Sep 21, 2018 •
edited
Loading

Updates to the additional groups/auto-create features after a review by @adobeDan.

Changes include

  • Log "additional group" rule mapping
  • Don't allow multiple source rules to map to same target group
  • Catch regex substitution errors
  • Remove some superfluous and confusing checks

I've also added secondary org support because that was missing from the original PR.

fixes #386
fixes #392

@adorton-adobe
remove unnecessary identity type check
e32d34f
@adorton-adobe
raise exception in get_rule_options() if missing config
b0bcad6
@adorton-adobe
don't need uid anymore
8c64d72
@adorton-adobe
catch errors for additional rule ID and resolution
1d8f685
@adorton-adobe
don't need to filter member_groups in LDAP connector - already filter…
413f9ac 
…ed in rules.py

Fixes adobe-apiplatform#386
@adorton-adobe
refactor auto-create conditions
b8dbd43
@adorton-adobe
add comment about push mode and auto-create groups
abd8c0c
@adorton-adobe
prevent additional source group rules from mapping to same target group
bfebc4c
@adorton-adobe
ensure that the additional groups feature works with secondary orgs
cdc1c0b
@adorton-adobe
don't index unresolved additional target groups
b5f1ea9
@adorton-adobe
auto-create groups with respect to organization
0dafb50
@adorton-adobe
only target additional group to appropriate org
9e33265
@adorton-adobe
normalize additional target group and fix umapit connector name incon…
50fb6fb 
…sistency
@adorton-adobe
documentation updates
5cfaf6d
adobeDan
adobeDan approved these changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@adobeDan adobeDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant solution to the name collision issues in the original. Plus I like that you're adding support for multiple organizations in the creation.

@adorton-adobe adorton-adobe merged commit d63876f into adobe-apiplatform:v2 Nov 27, 2018
@adorton-adobe adorton-adobe added this to the v2.4 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adobeDan adobeDan adobeDan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

Log additional group mapping Refactor additional_group resolution
2 participants
@adorton-adobe @adobeDan