Skip to content

Ergonomic tweaks to template configs #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bhunut-adobe
Copy link
Collaborator

@bhunut-adobe bhunut-adobe commented Nov 21, 2018

PR Request for #425

I changed the following:

Removed Number from the sample template.

Connector-umapi.yml

  • set private key path to just private.key

Connector-ldap.yml

  • set page size to 1000 (Active Directory Default)
  • user_username_format example to just {sAMAccountName}

User-Sync-Config.yml

  • Default to FederatedID
  • Tweaked the example to match with current use case
  • Enable Logging by Default
  • Default Invocation - Set to Process-group and Users Mapped to avoid accidentally directory dump to Admin console.

@adorton-adobe adorton-adobe self-requested a review November 21, 2018 19:12
Copy link
Collaborator

@adorton-adobe adorton-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes. I do wonder if changing the defaults will have any unintended consequences, but I think it's OK to approve the change and test it.

@adorton-adobe adorton-adobe merged commit 69da131 into adobe-apiplatform:v2 Nov 21, 2018
@adorton-adobe adorton-adobe added this to the v2.4 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants