Skip to content

Log a meaningful error if Okta connector isn't invoked correctly #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

shasibhusanJena
Copy link
Contributor

added the log in app.py file, please review it. issue no #416

@adorton-adobe adorton-adobe added this to the v2.4 milestone Jan 17, 2019
Copy link
Collaborator

@adorton-adobe adorton-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't be adding any additional log messages to the general exception handler of the application. That handler will log any AssertionException the application throws.

You need to determine the best place to check for the error condition an throw an AssertionException. That check will very likely need to happen in the ConfigHandler class. I would start by looking at get_directory_connector_options and get_directory_connector_configs.

@adorton-adobe adorton-adobe modified the milestones: v2.4, v2.4.1 Jan 25, 2019
@shasibhusanJena
Copy link
Contributor Author

  • removed line from app.py default AssertionException block
  • added a separate code block on config.py file to validate this condition.

@shasibhusanJena
Copy link
Contributor Author

raised a new pull request from Branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants