V2 for release 2.4 #443
V2 for release 2.4 #443
Conversation
Added generic log stmt to retrieve values using LDAP
Added generic log stmt to retrieve values using LDAP
… separate code block on config.py file to validate this condition.
removed connectors_config.accessed_keys loop and checking with container value comparision with JSON object #416
|
@shasibhusanJena You don't need to make new PR when you make new commits. Just commit to the branch the PR is coming from and they'll be picked up here. |
|
oh, I was not knowing about it before, that will be easy then. thanks |
There was a problem hiding this comment.
I think you've found the right place to do this check. After doing some testing, I've found that we need to make this check more generic so we always require a directory connector config for all connector types except for CSV. I've also made some other notes - please review.
user_sync/config.py
Outdated
| @@ -323,6 +323,11 @@ def get_directory_connector_options(self, connector_name): | |||
| """ | |||
| options = {} | |||
| connectors_config = self.get_directory_connector_configs() | |||
|
|
|||
| if ( 'okta' in connectors_config.value) and (connector_name == 'ldap'): | |||
There was a problem hiding this comment.
Now that I've had more time to look at this, I think we need to make this check more generic. If you do the opposite of what we're checking here - enable the link to the Okta config, but make sure the --connector is "ldap" - then we still get an unhelpful message.
The check should ensure that the correct config file is specified for the connector type. The only exception is CSV, which does not require a configuration file.
Here is how I would modify your check:
if connector_name != 'csv' and connector_name not in connectors_config.value:
# ... rest of checkYou will also need to change the error message - I'll address that separately.
user_sync/config.py
Outdated
|
|
||
| if ( 'okta' in connectors_config.value) and (connector_name == 'ldap'): | ||
| if connectors_config.accessed_keys is not None: | ||
| raise AssertionException("Failed to match request : for Okta Connector type receiving LDAP as input type from commnand line") |
There was a problem hiding this comment.
If you make the check more generic you'll need to make this message generic as well. I'd do something like this:
raise AssertionException("Config file must be specified for connector type '{}'".format(connector_name))There was a problem hiding this comment.
modified. please review
removed connectors_config.accessed_keys and made it more generic to find correct type
… separate code block on config.py file to validate this condition.
-- doing a comparison with connectors_config. the value so that, don't have to loop through to make a conditional check "Okta" type