Mac: KeyBindingManager displays errant error message

[redmunds]

Recipe:

1. Start Brackets with no extensions installed
2. Look in console to see this error message

Cannot assign Cmd-G to navigate.gotoLine. It is already assigned to edit.findNext
command/KeyBindingManager.js:418

The shortcut keys are defined in src/base-config/keyboard.json as follows:

    "navigate.gotoLine":  [
        {
            "key": "Ctrl-G"
        },
        {
            "key": "Cmd-L",
            "platform": "mac"
        }
    ],

I guess that error message is to be expected since the all-platform shortcut is defined first. It would be nice if KeyBingingManager looked for an alternate mac shortcut definition before declaring an error.

Even worse, is if I change the order to put the mac-specific shortcut first as follows:

    "navigate.gotoLine":  [
        {
            "key": "Cmd-L",
            "platform": "mac"
        },
        {
            "key": "Ctrl-G"
        }
    ],

I still get the error.

Specifying specific shortcuts for both Mac and Win as follows gets rid of the error:

    "navigate.gotoLine":  [
        {
            "key": "Ctrl-G",
            "platform": "win"
        },
        {
            "key": "Cmd-L",
            "platform": "mac"
        }
    ],

But, this is undesirable because every new platform (e.g. "linux") will have to specifically add a shortcut.

[jasonsanjose]

Confirmed fixed. But needs additional change to support multiple bindings and change message from error to log. Closing this issue. See pull #4338.

[redmunds]

I'll take a stab at this one for Sprint 31.

[redmunds]

This code is operating as designed. The problem is the way the key bindings are specified. For example:

    "navigate.gotoLine":  [
        {
            "key": "Ctrl-G"
        },
        {
            "key": "Cmd-L",
            "platform": "mac"
        }
    ],

It's implied that the first key binding does not apply to mac platform, because there is a subsequent binding that does specify mac platform, but there's no way for the code to know that. It's valid to specify multiple bindings. and the base key in the first binding (G) is different from the second binding (L), so there's no conflict that is overridden.

What's needed is a way to specify "all platforms except certain one(s)". For example:

    "navigate.gotoLine":  [
        {
            "key": "Ctrl-G"
            "platform-exception": "mac"
        },
        {
            "key": "Cmd-L",
            "platform": "mac"
        }
    ],

That terminology seems a bit awkward, so I am open to any other suggestions.

cc @jasonsanjose

[TomMalbran]

What if we reverse the order of the key bindings. First the platform specific bindings and at the last position the default one, and make it work just like a switch?

    "navigate.gotoLine":  [
        {
            "key": "Cmd-L",
            "platform": "mac"
        },
        {
            "key": "Ctrl-G"
        }
    ],

The code then grabs the first and uses it if is for mac and doesn't even check the rest. If is not mac it goes to the next one. Since this one has no platform, is considered as the default value and it uses that one. It should work like a switch.