This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Rlim/cmd or ctrl issue #1114
Merged
Rlim/cmd or ctrl issue #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +245,8 @@ define(function (require, exports, module) { | |||
|
|
|||
| if (brackets.platform === "mac") { | |||
| displayStr = descriptor.replace(/-/g, ""); // remove dashes | |||
| displayStr = displayStr.replace("Ctrl", "\u2318"); // Ctrl > command symbol | |||
| displayStr = displayStr.replace("Ctrl", "\u2303"); // Ctrl > command symbol | |||
There was a problem hiding this comment.
Oops... need to update the comment
ghost
assigned
|
Reviewing |
|
I tried debugging this and it appears that brackets-app or maybe CEF is swallowing both CTRL+Tab and SHIFT+CTRL+Tab. This looks like a blocker for this bug fix. We may have to push this out. Do either of these work for you? |
|
Oops, nevermind. I see that the document switching command has never worked on mac. We have issue #938 open to track that. I was able to verify that Ctrl on mac works in other commands. Ignore my prior comment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1004