This repository was archived by the owner on Sep 6, 2021. It is now read-only.
nls readme.md update #8438
Merged
nls readme.md update #8438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first thought of previous sentence was the hash of the actual strings.js.
|
@sbruchmann , Thanks for pointing it out. Typo fixed. |
|
Typo fixed. I think I have to go to sleep now, it is 2:00AM here~ |
|
Triage complete. @tan9 Thanks for the cleaning this up. I notice that there are several places in this file that describe inserting/updating SHA comment at end of strings.js file. I think it would simplify this file if a section were added with this info, and then references to the "sha" section added in all of the other places. Do you care to make that change? |
|
Thanks. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.