Fix strict mode storybook #3837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this change we get a constant rendered more hooks than last render error
| @@ -24,9 +24,9 @@ export const parameters = { | |||
| }; | |||
|
|
|||
| export const decorators = [ | |||
| Story => ( | |||
| story => ( | |||
There was a problem hiding this comment.
you know, we can probably get rid of this decorator, there are story options that do this now using layout: center
https://storybook.js.org/docs/react/configure/story-layout
There was a problem hiding this comment.
Will investigate this option later for the decorator I'll be adding to support scrolling in all stories
snowystinger
approved these changes
Dec 20, 2022
| <VerticalCenter style={{alignItems: 'center', minHeight: '100vh', boxSizing: 'border-box', display: 'flex', justifyContent: 'center'}}> | ||
| <Story /> | ||
| {story()} |
There was a problem hiding this comment.
didn't we make this change originally because it was crashing storybook as you have it now?
|
I confused myself and Rob haha, this PR is no longer needed, superceded by #3333 now that I've got that one working |
This was referenced Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this branch for strict mode testing + fixes for now. Will explore fixing this via the strict mode toggle PR
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
RSP