chore: Update to Node 20 #6385
Merged
chore: Update to Node 20 #6385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
1 similar comment
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
snowystinger
commented
Apr 16, 2025
| @@ -102,6 +106,11 @@ async function build() { | |||
|
|
|||
| // Copy necessary code and configuration over | |||
| fs.copySync(path.join(srcDir, 'packages', '@adobe', 'spectrum-css-temp'), path.join(dir, 'packages', '@adobe', 'spectrum-css-temp')); | |||
| try { | |||
There was a problem hiding this comment.
note, this is only needed temporarily, once we do a release, we can delete this code because then the code we compare to on main will have the spectrum-css tools in source
# Conflicts: # yarn.lock
devongovett
approved these changes
May 7, 2025
dannify
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6380
Note I copied in the spectrum-css builder in order to get rid of a bunch of dependencies which were incompatible with node 20 and update some of the tooling around it. You should be able to compare against what is in your local node_modules if you haven't pulled this down. Otherwise, you'll have to look at it elsewhere, such as here:
https://app.unpkg.com/@spectrum-css/[email protected]
It passed chromatic, you can check that on commit 6dc0c43
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: