-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: Refactor codemods #8056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: Refactor codemods #8056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/dev/codemods/src/s1-to-s2/src/codemods/components/ActionGroup/transform.ts
Show resolved
Hide resolved
snowystinger
approved these changes
Apr 16, 2025
packages/dev/codemods/src/s1-to-s2/src/codemods/components/Button/transform.ts
Show resolved
Hide resolved
dannify
approved these changes
May 7, 2025
Let's get this merged and test it next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to add and maintain S1 to S2 codemods in the future.
Codemods are now split up by component in
src/codemods/components/
.So to add a Button codemod:
src/codemods/components/Button/transform.ts
if it doesn't existremoveProp
)__tests__/button.test.ts
✅ Pull Request Checklist:
📝 Test Instructions:
Unit tests should validate that all the transforms are still correctly applied, but it would be good to build and test that it still works end-to-end:
cd packages/dev/codemods && yarn build
Change directories to an example app
node ../../packages/dev/codemods/dist/index.js s1-to-s2
🧢 Your Project: