Skip to content

chore: update remix example #8090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

chore: update remix example #8090

merged 3 commits into from
Apr 17, 2025

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Apr 13, 2025 •
edited
Loading

Closes

Looks like a recent-ish release of remix removed the unstable prefix, also with the new process.env variables, it broke the build

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Apr 13, 2025

Build successful! 🎉

@snowystinger snowystinger mentioned this pull request Apr 13, 2025
Merged
@rspbot
Copy link

rspbot commented Apr 13, 2025

Build successful! 🎉

reidbarber
reidbarber previously approved these changes Apr 14, 2025
View reviewed changes
yihuiliao
yihuiliao previously approved these changes Apr 16, 2025
View reviewed changes
@snowystinger snowystinger dismissed stale reviews from yihuiliao and reidbarber via f6108c8 April 16, 2025 23:34
@rspbot
Copy link

rspbot commented Apr 16, 2025

Build successful! 🎉

@snowystinger snowystinger added this pull request to the merge queue Apr 17, 2025
Merged via the queue into main with commit 104d441 Apr 17, 2025
31 checks passed
@snowystinger snowystinger deleted the update-remix-example-app branch April 17, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snowystinger @rspbot @reidbarber @yihuiliao