Skip to content

fix: TableView jump to top on asynchronous load #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obreitwi
Copy link

@obreitwi obreitwi commented Apr 23, 2025

Closes #8132.

We confirmed that this PR resolves the issue internally, but I will provide a minimal example for easier verification.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

(will provide once minimal example is ready)

🧢 Your Project:

(not applicable)

@yihuiliao
Copy link
Member

yihuiliao commented Apr 30, 2025

Thanks for the PR! You'll need to sign the CLA for all the checks to pass. If you could provide a minimal example (storybook) for easier verification that would be great. Otherwise, the changes make sense but we'll need to test.

@dannify dannify added the waiting Waiting on Issue Author label May 7, 2025
@snowystinger
Copy link
Member

Let us know if you cannot sign the CLA so we know what action to take. Thank you!

@obreitwi obreitwi closed this May 30, 2025
@obreitwi obreitwi reopened this May 30, 2025
@obreitwi
Copy link
Author

Hey, thank you for responding! I just signed the CLA (sorry for taking so long).

I am also a bit hard-pressed on time to provide a minimal solution, but the bug should become apparent whenever you use paged async loading on a table view and the individual rows are permitted to be of different heights (via overflowMode="wrap").

And just as a heads-up: We've noticed that while the original issue #8132 is indeed fixed, there are still occasional rendering issues where the table view does not get populated with all loaded rows at the bottom. A workaround for users is to scroll up and down a bit to trigger a re-render which typically fixes it.

An deeper investigation is pending on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting Waiting on Issue Author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableView with overflowMode="wrap": Scroll position jumps to top after asynchronous loads
4 participants