Skip to content

fix: Fix S2 menu keyboard shortcut icons background color when hovered/focused #8153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: Fix S2 menu keyboard shortcut icons background color when hovered/focused #8153

merged 1 commit into from
Apr 30, 2025

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Apr 28, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Apr 28, 2025

Build successful! 🎉

@LFDanLu
Copy link
Member Author

LFDanLu commented Apr 28, 2025

https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=937

@LFDanLu LFDanLu added the small review Easy to review PR label Apr 28, 2025
@LFDanLu LFDanLu added this pull request to the merge queue Apr 30, 2025
Merged via the queue into main with commit 6328d20 Apr 30, 2025
32 checks passed
@LFDanLu LFDanLu deleted the fix_menu_keyboard_selection branch April 30, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees
No one assigned
Labels
small review Easy to review PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LFDanLu @rspbot @reidbarber @yihuiliao