fix(numberfield): preserve validation errors on blur when value unchanged#9629
Open
kaigritun wants to merge 1 commit intoadobe:mainfrom
Open
fix(numberfield): preserve validation errors on blur when value unchanged#9629kaigritun wants to merge 1 commit intoadobe:mainfrom
kaigritun wants to merge 1 commit intoadobe:mainfrom
Conversation
…nged When a NumberField has validation errors (e.g., from Form validationErrors), focusing and blurring the field without changing its value would incorrectly reset the validation state, removing the data-invalid attribute. This fixes the issue by checking if the input value has actually changed from the state's inputValue before calling commitAndAnnounce() on blur. Fixes adobe#9444
snowystinger
previously approved these changes
Feb 9, 2026
Member
snowystinger
left a comment
There was a problem hiding this comment.
Awesome, thanks for the PR so quickly and for the test!
doh, spoke too fast, it's failing tests :(
snowystinger
reviewed
Feb 9, 2026
| commitAndAnnounce(); | ||
| // Only commit if the input value has actually changed from the state's input value. | ||
| // This prevents validation from being reset when the user focuses and blurs without editing. | ||
| if (inputRef.current?.value !== inputValue) { |
Member
There was a problem hiding this comment.
Probably need to track the previous input value from the last commit, or increment/decrement instead of inputValue, since by the time the user blurs the inputValue will always be the inputRef's current value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a NumberField has validation errors (e.g., from Form
validationErrorsprop), focusing and then blurring the field without changing its value would incorrectly reset the validation state, removing thedata-invalidattribute.Changes
In
useNumberField.ts, theonBlurhandler now checks if the input value has actually changed from the state'sinputValuebefore callingcommitAndAnnounce(). This preventscommit()from being called (and thuscommitValidation()from resetting the validation state) when the user simply focuses and blurs without editing.Reproduction
From issue #9444:
Testing
Added a test case that verifies validation errors are preserved when focusing and blurring without changing the value.
All existing NumberField tests pass.
Fixes #9444