Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/@react-aria/selection/src/useSelectableCollection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ export function useSelectableCollection(options: AriaSelectableCollectionOptions
}
};

if (manager.selectionMode === 'single' && (e.metaKey || e.altKey)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close, but it's going to affect too many things. I think it should be restricted to Left/Right arrows OR handling should be moved to the Tab's keyboard delegate.
Otherwise it may interfere with some of our selectionMode+selectionBehaviour https://react-aria.adobe.com/ListBox#selection

It looks like Up/Down + meta scrolls the entire page or moves the text cursor to the start or end of an input. I think in Tabs it shouldn't do anything. Much like the Toolbar in this github comment box.

return;
}

switch (e.key) {
case 'ArrowDown': {
if (delegate.getKeyBelow) {
Expand Down