feat: expose isRequired in render props for DateField, TimeField, DatePicker, and DateRangePicker#9659
Open
solssak wants to merge 1 commit intoadobe:mainfrom
Open
feat: expose isRequired in render props for DateField, TimeField, DatePicker, and DateRangePicker#9659solssak wants to merge 1 commit intoadobe:mainfrom
solssak wants to merge 1 commit intoadobe:mainfrom
Conversation
b06dca9 to
40f8df8
Compare
…ePicker, and DateRangePicker
40f8df8 to
65075f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #9643
Adds
isRequiredas a direct render prop anddata-requireddata attribute toDateField,TimeField,DatePicker, andDateRangePicker, matching the existing pattern used byTextField,NumberField, and other field components.Changes
Source (
packages/react-aria-components/src/)DateField.tsx
isRequired: booleantoDateFieldRenderPropsinterface (shared by bothDateFieldandTimeField)isRequired: props.isRequired || falsetouseRenderPropsvalues inDateFielddata-requireddata attribute toDateFieldouter elementisRequired: props.isRequired || falsetouseRenderPropsvalues inTimeFielddata-requireddata attribute toTimeFieldouter elementDatePicker.tsx
isRequired: booleantoDatePickerRenderPropsinterface (inherited byDateRangePickerRenderPropsviaOmit<DatePickerRenderProps, 'state'>)isRequired: props.isRequired || falsetouseRenderPropsvalues inDatePickerdata-requireddata attribute toDatePickerouter elementisRequired: props.isRequired || falsetouseRenderPropsvalues inDateRangePickerdata-requireddata attribute toDateRangePickerouter elementTests (
packages/react-aria-components/test/)should support required render propandshould support required statetestsshould support required render propandshould support required statetestsshould support required render propandshould support required statetestsshould support required render propandshould support required statetestsBefore / After
Before:
After:
Now consistent with
TextField,NumberField, and other field components.