Skip to content

feat(slider): S2 migration, new precision variant, embedded textfield #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: spectrum-two
Choose a base branch
from

Conversation

aramos-adobe
Copy link
Contributor

@aramos-adobe aramos-adobe commented Jun 11, 2025

Description

CSS-1201
CSS-1202

S2 slider migration changes:

  • New default and precision handles
  • Track fill for ramp, offset, range and default filled have emphasized states
  • More expansive grid for visual testing
  • Embedded textfield component for editable variant
  • Adjustable track heights ie. thin vs thick
  • Updated offset variant (ie. the track starts at the center)

New tokens

--spectrum-slider-control-to-field-label-editable-extra-large
--spectrum-slider-control-to-field-label-editable-large
--spectrum-slider-control-to-field-label-editable-medium
--spectrum-slider-control-to-field-label-editable-small
--spectrum-slider-control-to-side-field-label-extra-large
--spectrum-slider-control-to-side-field-label-large
--spectrum-slider-control-to-side-field-label-medium
--spectrum-slider-control-to-side-field-label-small
--spectrum-slider-control-to-text-field-extra-large
--spectrum-slider-control-to-text-field-large
--spectrum-slider-control-to-text-field-medium
--spectrum-slider-control-to-text-field-small
--spectrum-slider-editable-control-to-field-label
--spectrum-slider-editable-control-to-text-field
--spectrum-slider-editable-field-inline-size-extra-large
--spectrum-slider-editable-field-inline-size-large
--spectrum-slider-editable-field-inline-size-medium
--spectrum-slider-editable-field-inline-size-small
--spectrum-slider-emphasized-track-fill-color
--spectrum-slider-precision-handle-height
--spectrum-slider-precision-handle-height-extra-large
--spectrum-slider-precision-handle-height-large
--spectrum-slider-precision-handle-height-medium
--spectrum-slider-precision-handle-height-small
--spectrum-slider-precision-handle-width
--spectrum-slider-handle-extra-large
--spectrum-slider-handle-large
--spectrum-slider-handle-medium
--spectrum-slider-handle-small

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Open the storybook for the slider component:
    - [ ] Precision handle for all shirt sizes
    - [ ] Precision handle on slider variants (ramp, offset, range)
    - [ ] Perspective onclick down on precision and default handle
    - [ ] Emphasized track is visible
    - [ ] Interaction states are visible for variants and embedded components

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

Copy link

changeset-bot bot commented Jun 11, 2025

🦋 Changeset detected

Latest commit: dacccde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@spectrum-css/slider Major
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aramos-adobe aramos-adobe self-assigned this Jun 11, 2025
@aramos-adobe aramos-adobe marked this pull request as draft June 11, 2025 14:09
Copy link
Contributor

github-actions bot commented Jun 11, 2025

File metrics

Summary

Total size: 1.42 MB*
Total change (Δ): 🔴 ⬆ 4.48 KB (0.31%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Minified Gzipped Δ
slider 31.31 KB 29.56 KB 4.05 KB 🔴 ⬆ 1.83 KB

File change details

slider

Filename Head Minified Gzipped Compared to base
index.css 31.31 KB 29.56 KB 4.05 KB 🔴 ⬆ 1.83 KB
metadata.json 14.83 KB - - 🔴 ⬆ 2.02 KB

tokens

Filename Head Minified Gzipped Compared to base
css/dark-vars.css 46.16 KB - - -
css/global-vars.css 80.22 KB - - -
css/index.css 261.51 KB - - 🔴 ⬆ 2.24 KB
css/large-vars.css 45.29 KB - - 🔴 ⬆ 1.12 KB
css/light-vars.css 46.16 KB - - -
css/medium-vars.css 45.41 KB - - 🔴 ⬆ 1.12 KB
json/tokens.json 410.29 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

Copy link
Contributor

github-actions bot commented Jun 11, 2025

🚀 Deployed on https://pr-3945--spectrum-css.netlify.app

@aramos-adobe aramos-adobe changed the title Aramos-adobe/css1201-s2-slider-handle-variant feat(slider): S2 migration, new precision variant, embedded textfield Jun 12, 2025
@aramos-adobe aramos-adobe added size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete. S2 Spectrum 2 labels Jun 12, 2025
@aramos-adobe aramos-adobe marked this pull request as ready for review June 17, 2025 14:50
@aramos-adobe
Copy link
Contributor Author

Things left to do:

  • Configure WHCM for all states and variants
  • Review base & CJK typography for labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S2 Spectrum 2 size-5 L ~30-42hrs; lots of effort or complexity, most of a sprint needed to complete.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant