Skip to content

feat: enable allowUnknownFlags for specific commands #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

Melchyore
Copy link
Contributor

@Melchyore Melchyore commented Apr 20, 2025

πŸ”— Linked issue

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

According to the AdonisJS documentation, commands can accept unknown flags, which can be used in stubs to customize behavior such as output destination.

However, by default, the allowUnknownFlags option is disabled, preventing this feature from working as intended.

This PR enables the allowUnknownFlags option for specific commands that benefit from accepting and using additional flagsβ€”restoring alignment with the documented behavior. This is useful when using modular architecture.

If this PR is approved and merged, similar changes will be proposed for other packages like Lucid, Mail, and so on. (Edit: It appears that other packages have already enabled this option for make commands)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

Thanks @Melchyore πŸ™

@thetutlage thetutlage merged commit 6fdf953 into adonisjs:6.x Apr 21, 2025
6 checks passed
@Melchyore
Copy link
Contributor Author

Melchyore commented Apr 21, 2025

Thanks @Melchyore πŸ™

Many thanks for accepting this PR. I will work on the other packages right now. (Edit: It appears that other packages have already enabled this option for make commands)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants