fix(response): use never return type for abort method #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @thetutlage |
|
Ping. Even if we don't find a solution for |
|
Yeah, we need inverse of |
Do you want me to add that to this PR? |
|
Yeah, let's get them out together |
This method is the inverse of abortIf. It allows to use type assertions to make TypeScript narrow types if the function threw.
|
Done. |
targos
commented
Dec 19, 2019
| test('abortUnless: abort request when condition is falsy', async (assert) => { | ||
| const server = createServer((req, res) => { | ||
| const config = fakeConfig() | ||
| const response: Response = new Response(req, res, config) |
There was a problem hiding this comment.
See microsoft/TypeScript#33622
It is necessary here to explicitly declare the type of Response. In practice in Adonis, the type is already defined in the context so the user doesn't have to do anything.
Example with the change, where TS correctly determined that the code after the call is unreachable:
|
Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to use the new feature that TypeScript added for assertions functions to fix the type of
abortIfbut couldn't find a way.abortIfis implemented in the opposite way (throws if the condition is truthy) than usual assertions.Ref: https://devblogs.microsoft.com/typescript/announcing-typescript-3-7/#assertion-functions