Thanks, @thunze for reporting this!
hermes subcommands take arbitrary options under the -O argument. These have been logged in raw form since softwarepub/hermes@7f64f10 in: https://github.com/softwarepub/hermes/blob/3a92f42b2b976fdbc2c49a621de6d665364a7cee/src/hermes/commands/cli.py#L66
If users provide sensitive data such as API tokens (e.g., via hermes deposit -O invenio_rdm.auth_token SECRET), these are written to the log file in plain text, making them available to whoever can access the log file.
Impact
As currently, hermes.log is not yet uploaded automatically as an artifact in CI, this vuln impacts:
- local users working on shared access computers, where logs may be written to a commonly accessible file system
- CI users whose CI logs are accessible to others, e.g., through group or organization rights
Potentially, if the changes merged from softwarepub/ci-templates#13 are merged into ci-templates via softwarepub/ci-templates#14, this would automate the disclosure of Invenio auth tokens at least for all CI runs against Invenio instances!
Patches
This has been patched in hermes 0.9.1 by masking all values passed using -O.
Workarounds
Upgrade to hermes >= 0.9.1.
References
Thanks, @thunze for reporting this!
hermessubcommands take arbitrary options under the-Oargument. These have been logged in raw form since softwarepub/hermes@7f64f10 in: https://github.com/softwarepub/hermes/blob/3a92f42b2b976fdbc2c49a621de6d665364a7cee/src/hermes/commands/cli.py#L66If users provide sensitive data such as API tokens (e.g., via
hermes deposit -O invenio_rdm.auth_token SECRET), these are written to the log file in plain text, making them available to whoever can access the log file.Impact
As currently,
hermes.logis not yet uploaded automatically as an artifact in CI, this vuln impacts:Potentially, if the changes merged from softwarepub/ci-templates#13 are merged into
ci-templatesvia softwarepub/ci-templates#14, this would automate the disclosure of Invenio auth tokens at least for all CI runs against Invenio instances!Patches
This has been patched in
hermes0.9.1 by masking all values passed using-O.Workarounds
Upgrade to
hermes>= 0.9.1.References