Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

Conversation

@brandonwillard
Copy link
Member

This PR provides multiple aesara.tensor.random updates (e.g. removes the unnecessary Observed Op, exposes RandomVariables via aesara.tensor.random, etc.). It also allows the use of numpy.dtype instances (e.g. numpy.int64) as dtype arguments during tensor and scalar construction, as well as aesara.tensor.cast.

ricardoV94
ricardoV94 previously approved these changes May 23, 2021
Copy link
Contributor

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

On a separate note, none of these random methods show up in the docs do they?

@brandonwillard
Copy link
Member Author

On a separate note, none of these random methods show up in the docs do they?

I don't recall updating the list manually, but definitely seems like something that should be generated automatically.

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #436 (ccede9b) into master (1c11dd4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
- Coverage   72.45%   72.44%   -0.01%     
==========================================
  Files         173      173              
  Lines       55651    55640      -11     
==========================================
- Hits        40320    40309      -11     
  Misses      15331    15331              
Impacted Files Coverage Δ
aesara/link/numba/dispatch.py 98.09% <ø> (-0.01%) ⬇️
aesara/scalar/basic.py 84.68% <100.00%> (+<0.01%) ⬆️
aesara/tensor/basic.py 88.73% <100.00%> (+<0.01%) ⬆️
aesara/tensor/random/basic.py 100.00% <100.00%> (ø)
aesara/tensor/random/op.py 99.32% <100.00%> (-0.06%) ⬇️
aesara/tensor/type.py 93.35% <100.00%> (ø)

@brandonwillard brandonwillard merged commit 1366221 into aesara-devs:master May 23, 2021
@brandonwillard brandonwillard deleted the rv-bcast-cast branch May 23, 2021 23:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose aesara.tensor.random.basic via aesara.random Infer RandomVariable broadcastable pattern when size has a Cast

2 participants