fix: add missing 'Sabah' to supported region list #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Hafiq Iqmal 👋🏻
This pull request fixes Fatal error when filtering by state Sabah: Class "HttpException" not found, where the state Sabah was missing from the list of supported regions in the
MalaysiaHolidayclass.🛠️ Changes made:
'Sabah'to theself::$region_arrayinMalaysiaHoliday.php.🐛 Root Cause:
The
checkRegional()method validates the requested region against theself::$region_array. Since'Sabah'was not listed, any request involving'Sabah'resulted in aRegionException, causing the script to fail when attempting to fetch holidays for that region.✅ Testing:
I verified the fix by running the following code:
This now successfully returns holiday data for Sabah in 2025 without throwing an exception.
Closes #12