Skip to content

Conversation

@nectarindev
Copy link

@nectarindev nectarindev commented Dec 2, 2025

Description

Fixes #2693

Changes

  • New feature (a non-breaking change that adds functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (just lint shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running just test-coverage
  • I have ensured that static analysis tests are passing by running just static-analysis
  • I have included code examples to illustrate the modifications

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

@nectarindev
Copy link
Author

The current implementation merges the broker context into the application context, so a single context will be shared between multiple brokers.
I tried to make the context isolated between brokers, but the mutable design of the library makes this very difficult. If I merge the application context into the broker context, subsequent changes to the application context, such as a modification in app.on_startup, will not be visible in the brokers context.

If the current version is accepted, I would further supplement the documentation.

@nectarindev nectarindev force-pushed the feature/merge-contexts branch from 477550f to 7350ef9 Compare December 17, 2025 20:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 17, 2025
@nectarindev nectarindev marked this pull request as ready for review December 17, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: merge Broker(context=...) and FastStream(context=...) at broker-level

3 participants