Skip to content

fix(approval): /approve shorthand ignores request_id argument#4014

Merged
rayrayraykk merged 1 commit intoagentscope-ai:mainfrom
xieyxclack:xieyx/bugfix/approve
May 6, 2026
Merged

fix(approval): /approve shorthand ignores request_id argument#4014
rayrayraykk merged 1 commit intoagentscope-ai:mainfrom
xieyxclack:xieyx/bugfix/approve

Conversation

@xieyxclack
Copy link
Copy Markdown
Member

Description

/approve <request_id> silently ignored the request_id and always approved the queue head. The handler now extracts request_id from _raw_args, matching DenyCommandHandler's existing pattern.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Refactoring

Component(s) Affected

  • Core / Backend (app, agents, config, providers, utils, local_models)
  • Console (frontend web UI)
  • Channels (DingTalk, Feishu, QQ, Discord, iMessage, etc.)
  • Skills
  • CLI
  • Documentation (website)
  • Tests
  • CI/CD
  • Scripts / Deploy

Checklist

  • I ran pre-commit run --all-files locally and it passes
  • If pre-commit auto-fixed files, I committed those changes and reran checks
  • I ran tests locally (pytest or as relevant) and they pass
  • Documentation updated (if needed)
  • Ready for review

For Channel Changes (DingTalk, Feishu, QQ, Console, etc.)

  • I ran ./scripts/check-channels.sh (or ./scripts/check-channels.sh --changed) and it passes
  • Contract test exists in tests/contract/channels/test_<channel>_contract.py (REQUIRED)
  • Contract test implements create_instance() with proper channel initialization
  • All 19 contract verification points pass (see tests/contract/channels/__init__.py)
  • Optional: Unit tests in tests/unit/channels/test_<channel>.py for complex internal logic

Testing

[How to test these changes]

Local Verification Evidence

pre-commit run --all-files
# paste summary result

pytest
# paste summary result

Additional Notes

[Optional: any other context]

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

Welcome to QwenPaw! 🐾

Hi @xieyxclack, this is your 134th Pull Request.

🙌 Join Developer Community

Thanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page:
https://qwenpaw.agentscope.io/docs/community

We truly appreciate your enthusiasm—and look forward to your future contributions! 😊

We'll review your PR soon.

@rayrayraykk rayrayraykk merged commit 27579ce into agentscope-ai:main May 6, 2026
19 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in QwenPaw May 6, 2026
cofly-io pushed a commit to cofly-io/xClaw that referenced this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants