fix(approval): /approve shorthand ignores request_id argument#4014
Merged
rayrayraykk merged 1 commit intoagentscope-ai:mainfrom May 6, 2026
Merged
fix(approval): /approve shorthand ignores request_id argument#4014rayrayraykk merged 1 commit intoagentscope-ai:mainfrom
rayrayraykk merged 1 commit intoagentscope-ai:mainfrom
Conversation
|
Hi @xieyxclack, this is your 134th Pull Request. 🙌 Join Developer CommunityThanks so much for your contribution! We'd love to invite you to join the official QwenPaw developer group! You can find the Discord and DingTalk group links under the "Developer Community" section on our docs page: We truly appreciate your enthusiasm—and look forward to your future contributions! 😊 We'll review your PR soon. |
rayrayraykk
approved these changes
May 6, 2026
cofly-io
pushed a commit
to cofly-io/xClaw
that referenced
this pull request
May 6, 2026
…cope-ai#4014) (cherry picked from commit 27579ce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
/approve <request_id>silently ignored the request_id and always approved the queue head. The handler now extracts request_id from_raw_args, matchingDenyCommandHandler's existing pattern.Type of Change
Component(s) Affected
Checklist
pre-commit run --all-fileslocally and it passespytestor as relevant) and they passFor Channel Changes (DingTalk, Feishu, QQ, Console, etc.)
./scripts/check-channels.sh(or./scripts/check-channels.sh --changed) and it passestests/contract/channels/test_<channel>_contract.py(REQUIRED)create_instance()with proper channel initializationtests/contract/channels/__init__.py)tests/unit/channels/test_<channel>.pyfor complex internal logicTesting
[How to test these changes]
Local Verification Evidence
Additional Notes
[Optional: any other context]