fix(memory): return actual deleted count in AsyncSQLAlchemyMemory#1539
Open
Ricardo-M-L wants to merge 2 commits intoagentscope-ai:mainfrom
Open
fix(memory): return actual deleted count in AsyncSQLAlchemyMemory#1539Ricardo-M-L wants to merge 2 commits intoagentscope-ai:mainfrom
Ricardo-M-L wants to merge 2 commits intoagentscope-ai:mainfrom
Conversation
When content blocks have a text field set to None (e.g., {"text": None}),
the code would crash with a TypeError when calling str.join(). This change
uses .get("text") instead of direct indexing to safely handle cases where
text is None or missing.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The delete() and delete_by_mark() methods were returning the number of message IDs provided rather than the actual number of messages deleted. This could cause issues in code that relies on the return value to determine how many messages were actually removed. Now we use result.rowcount to return the actual count from the database. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Return actual deleted count in AsyncSQLAlchemyMemory instead of always returning a fixed value.
🤖 Generated with Claude Code