Fix inconsistency: updating lastUpdatedDepositCount on backwardLET & …#606
Open
Fix inconsistency: updating lastUpdatedDepositCount on backwardLET & …#606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
AgglayerBridgeL2contract to ensure that thelastUpdatedDepositCountvariable is correctly updated during both forward and backward LET (Leaf Event Tree) operations.Details
Contract logic improvements:
AgglayerBridgeL2.solcontract to setlastUpdatedDepositCountwhenever the LER (Local Exit Root) is updated in bothforwardLETandbackwardLEToperations, ensuring consistency between the deposit count and the last updated state. [1] [2]Testing enhancements:
lastUpdatedDepositCountis updated correctly after aforwardLEToperation, especially in emergency state scenarios.lastUpdatedDepositCountis updated correctly after abackwardLEToperation, including scenarios where the deposit count is rolled back.