HADOOP-18073. Address review comments. #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
reviewed
Nov 28, 2022
| .region(region) | ||
| .serviceConfiguration(serviceConfiguration); | ||
| S3Configuration serviceConfiguration = | ||
| S3Configuration.builder().pathStyleAccessEnabled(parameters.isPathStyleAccess()) |
There was a problem hiding this comment.
Is the layout/indent change intended?
| import org.apache.hadoop.util.Progressable; | ||
| import org.slf4j.Logger; |
There was a problem hiding this comment.
Isn't this supposed to go in the same block as software..?
| @@ -30,6 +30,8 @@ | |||
| import java.util.Map; | |||
| import java.util.concurrent.TimeUnit; | |||
|
|
|||
| import software.amazon.awssdk.core.exception.SdkException; | |||
| import org.apache.hadoop.util.Preconditions; | |||
| /** | ||
| * Common S3 HTTP header values used throughout the Amazon Web Services S3 Java client. | ||
| */ | ||
| public interface AWSHeaders { |
There was a problem hiding this comment.
Could this just be part of HeaderProcessing? If not, shouldn't it be in s3a.impl?
| String ETAG = "ETag"; | ||
| String LAST_MODIFIED = "Last-Modified"; | ||
|
|
||
| /* |
There was a problem hiding this comment.
Are the constants and comments just copied from v1 Headers? Is that ok?
passaro
approved these changes
Nov 28, 2022
ahmarsuhail
added a commit
that referenced
this pull request
Dec 9, 2022
addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]>
ahmarsuhail
added a commit
that referenced
this pull request
Jan 18, 2023
addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]>
ahmarsuhail
added a commit
that referenced
this pull request
May 15, 2023
addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]>
ahmarsuhail
added a commit
that referenced
this pull request
May 16, 2023
addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]>
ahmarsuhail
added a commit
that referenced
this pull request
May 17, 2023
addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]>
ahmarsuhail
added a commit
that referenced
this pull request
Aug 17, 2023
See aws_sdk_v2_changelog.md for details. Co-authored-by: Ahmar Suhail <[email protected]> Co-authored-by: Alessandro Passaro <[email protected]> HADOOP-18073. Address review comments. (#31) addresses review comments + yetus errors Co-authored-by: Ahmar Suhail <[email protected]> Move MultiObjectDeleteException to impl Reinstate old constants Move TransferManager initialization to ClientFactory Add unit tests for BlockingEnumeration Add unit tests for SelectEventStreamPublisher updates new providers in TestS3AAWSCredentialsProvider to V2 update GET range referrer header logic to V2 adds in unit check for bytes HADOOP-18565. Complete outstanding items for the AWS SDK V2 upgrade. (apache#5421) Changes include * use bundled transfer manager * adds transfer listener to upload * adds support for custom signers * don't set default endpoint * removes v1 sdk bundle, only use core package * implements region caching + many more Note: spotbugs is warning about inconsistent synchronization in accessing a new s3a FS field. This will be fixed in a follow-up patch. Contributed by Ahmar Suhail fixes issues after rebase Change-Id: I1d4b658979c725a88f6b54832bb7d106ffc2347d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWSCannedACLandAWSClientConfigto impl packagecom.amazonaws.services.s3.Headersimport, and instead adds in aAWSHeaderclass which includes only the headers S3A uses.