feat: improve date picker UI elements and utilities #131
Conversation
Adds quick selection features to date picker including: - Quick selection, refresh settings, and date ranges options - Consistent action button radius styling - Unified translation key mapping for date picker components
- Update NumericInput component usage across UI components - Replace tooltip-based translations with comprehensive translations map - Add new NumericInputTranslationKey support to shared translation keys - Update acore submodule to support enhanced translation system - Refactor _getNumericInputTranslations() method in multiple components
- Improve NumericInput translation system formatting consistency across UI components - Simplify task date field translations using centralized mapping approach - Enhance date range filter by removing redundant 3-month options and adding next_week selection - Update submodule acore to latest commit Relates to previous refactoring efforts for UI translation systems.
- Update ACore Flutter submodule to latest version - Refactor import paths for numeric input components - Add comprehensive tests for LRUCache, TimeSelector and QuickRangeSelector - Improve date range filter logic and fix indentation issues - Enhance performance benchmarks for date time picker components
…e filter - Update ACore submodule to latest commit - Add allowNullConfirm: true to DatePickerDialog to allow null selections
Move DialogSize enum and ResponsiveDialogHelper from local shared utils to ACore library to centralize responsive dialog functionality across the application
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @ahmet-cetinkaya, your pull request is larger than the review limit of 500000 diff characters
Summary of ChangesHello @ahmet-cetinkaya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant overhaul of UI components, particularly the date picker, and a strategic refactoring effort to centralize dialog utilities within the ACore Flutter library. These changes aim to improve user experience through enhanced functionality and responsiveness, while also streamlining the codebase for better maintainability and consistency. Additionally, the PR introduces a new comprehensive formatting script to ensure code quality and updates translation files to support the new features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This is an excellent pull request that significantly improves the codebase structure and maintainability. The migration of date picker UI elements and dialog utilities to the ACore library is a great step towards reusability. I'm particularly impressed with the comprehensive test suite you've added, including unit, widget, and performance tests for the new components. The updates to the shell scripts for formatting and changelog generation are also solid improvements.
I have one piece of feedback regarding the new localization keys, where I've noted some inconsistency in the placeholder syntax. Addressing this will ensure consistency across all locales.
Overall, this is a very well-executed and high-quality contribution. Great work!
Resolved conflicts: - Updated imports in habit_details_content.dart to use ACore NumericInput and proper sound manager service - Combined imports from both branches to maintain functionality
Update import paths across UI components to align with the new ACore library structure. The changes replace the verbose corePackages/acore/lib paths with the cleaner acore/components format, improving code readability and maintaining consistency with the updated package organization. This affects multiple feature areas including habits, tasks, settings, and shared components that utilize numeric input functionality.
- Replace double curly braces {{}} with single braces {} in ja.yaml, ko.yaml, tr.yaml
- Ensures consistent placeholder format across all locale files
- Addresses PR review feedback about i18n syntax inconsistency
- Prevents potential parsing issues and maintains standards compliance
…-elements feat: improve date picker UI elements and utilities
Summary
This PR improves the date picker UI components and refactors dialog utilities by migrating them to the ACore Flutter library for better reusability and consistency.
Key Changes
Test Plan
Files Changed
Breaking Changes