feat(tasks): add description dialog to quick task add component #137
Conversation
- Create DescriptionBuilder with buildContent and buildSimpleInput methods - Implement DescriptionDialogContent with markdown editor support - Add description functionality to QuickAddTaskDialog with toggle support - Include proper translation service integration for multilingual support - Add markdown editor with toolbar and proper styling
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @ahmet-cetinkaya, your pull request is larger than the review limit of 150000 diff characters
Summary of ChangesHello @ahmet-cetinkaya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the quick task add functionality by integrating a new description dialog, enabling users to add detailed context to tasks during rapid creation. This feature is supported by a major architectural refactoring of the quick task add component into a modular structure, improving maintainability. Additionally, date pickers now offer more intuitive quick selection options, and several core UI components have been centralized, alongside expanded localization efforts to provide a more robust and user-friendly experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- Resolved merge conflicts from main branch - Updated imports to use new acore package structure - Removed deprecated files (quick_add_task_dialog.dart, responsive_dialog_helper.dart) - Updated format script to use centralized version - Maintained feature branch changes while integrating main improvements - Updated translation files and dependency structure
- Fixed duplicate 'gen' entry causing YAML parsing error - Changed 'gen:icons' to 'gen-icons' to avoid conflict - Updated format script reference to use centralized version
- Fixed missed conflict markers from previous merge - Updated imports to use new acore package structure - Added ISoundPlayer import through service abstraction
## Issues Fixed ### Translation Keys - Added missing 'hoursShort', 'allDay', 'timePickerHourLabel', 'timePickerMinuteLabel' keys - Extended SharedTranslationKeys with date picker related constants ### Import & Package Structure - Fixed QuickAddTaskDialog imports to use acore package instead of deleted files - Updated generated file imports to use package imports instead of relative paths - Replaced deprecated ResponsiveDialogHelper and DialogSize with acore equivalents ### API Changes - Updated date picker API calls to remove deprecated 'confirmButtonText' parameter - Fixed DatePickerResult usage to check 'selectedDate' instead of 'isConfirmed' - Resolved dead null-aware expression warnings ### Code Generation - Fixed main.mapper.g.dart import paths for acore components - Corrected package references to use 'package:acore/' prefix - Resolved duplicate variable naming conflicts in generated files ## Results - ✅ Flutter analyze: No issues found (reduced from 34 to 0) - ✅ All imports resolved and working - ✅ Translation keys properly defined - ✅ Generated files fixed and compatible - ✅ Ready for development and testing Note: Web build fails due to SQLite FFI dependencies (expected for mobile app)
… improvements - Replace localized UI strings with English equivalents for date/time pickers - Update quick selection, refresh settings, and time display labels - Standardize time picker labels and improve consistency across locales - Add missing date picker configurations and field labels - Update numeric input controls with improved accessibility labels - Adjust date range validation messages and time constraints - Standardize hour/minute labels and all-day options across locales - Update tour and help text translations for consistency
|
/gemini review |
There was a problem hiding this comment.
Code Review
This is an excellent pull request that significantly improves the codebase. The refactoring of the QuickAddTaskDialog into smaller, more manageable components is a fantastic change that greatly enhances maintainability and readability. The new feature to add a task description from the quick add dialog is also a valuable addition to the user experience.
However, I've found a critical issue in the localization files. It appears that many of the translation files for shared components (src/lib/presentation/ui/shared/assets/locales/) have been partially overwritten with English text, particularly in the numeric_input and date_time_picker sections. This will break translations for numerous languages and needs to be addressed before merging. I've left specific comments on a couple of the affected files to highlight the problem.
src/lib/presentation/ui/features/tags/components/tag_select_dropdown.dart
Show resolved
Hide resolved
…translations Updated Czech (cs.yaml) and German (de.yaml) translation files with new date and time related strings, including date picker, time picker, and date range selection components. Also updated some existing translation strings for better accuracy. fixes localization inconsistencies in date/time components across UI
…eaks - Fixed DescriptionDialogContent constructor parameters mismatch causing dialog to not work - Resolved TextEditingController memory leaks in description dialog components - Restored proper description data flow from dialog to SaveTaskCommand - Converted DescriptionDialogContent to StatefulWidget with proper controller lifecycle - Fixed DescriptionBuilder SimpleDescriptionInput with proper memory management - Updated QuickAddTaskDialog to use correct DescriptionDialogContent API
Add success notification when tasks are created successfully with localized messages in 22 languages. Update icon sizing to use theme constants and improve visual feedback for lock settings in the quick add task dialog.
- Introduce NotificationPosition enum with top and bottom options - Add position parameter to OverlayNotificationHelper methods - Configure error notifications to appear at top on mobile platforms - Update AsyncErrorHandler to support configurable error notification position - Modify quick add task dialog to use platform-appropriate notification positioning
…alog feat(tasks): add description dialog to quick task add component
Summary
Description
This enhancement adds a description dialog to the quick task add functionality, allowing users to add detailed descriptions to tasks immediately after creation. The feature includes:
Key Changes
Testing
Screenshots
Note: Visual enhancements include the new description dialog with clean input interface
Type of Change
Checklist