Skip to content

Update README.md - #1

Merged
nnshah1 merged 2 commits into
mainfrom
Update-README.md
Mar 4, 2025
Merged

nnshah1 merged 2 commits into
mainfrom
Update-README.md

Conversation

@nvda-mesharma

Copy link
Copy Markdown
Contributor

No description provided.

@nnshah1
nnshah1 merged commit 5033457 into main Mar 4, 2025
@nnshah1
nnshah1 deleted the Update-README.md branch March 4, 2025 17:16
kylehh pushed a commit to kylehh/dynamo that referenced this pull request Apr 11, 2025
copy-pr-bot Bot pushed a commit that referenced this pull request Sep 9, 2025
* add metrics to disconnect

* fmt

* fmt

Signed-off-by: michaelfeil <me@michaelfeil.eu>
grahamking pushed a commit that referenced this pull request Sep 10, 2025
Signed-off-by: michaelfeil <me@michaelfeil.eu>
ayushag-nv pushed a commit that referenced this pull request Sep 15, 2025
Signed-off-by: michaelfeil <me@michaelfeil.eu>
Signed-off-by: ayushag <ayushag@nvidia.com>
zhongdaor-nv pushed a commit that referenced this pull request Sep 15, 2025
Signed-off-by: michaelfeil <me@michaelfeil.eu>
Signed-off-by: zhongdaor <zhongdaor@nvidia.com>
elyasmnvidian added a commit that referenced this pull request Sep 22, 2025
Signed-off-by: Elyas Mehtabuddin <emehtabuddin@nvidia.com>
kaim-eng added a commit that referenced this pull request Jun 8, 2026
Three Dockerfile bugs combined to make the DCGM-mode image unbuildable

on a fresh checkout. Fixing any one in isolation leaves the build broken,

so they travel together:

1. DCGM_IMAGE default 'nvcr.io/nvidia/cloud-native/dcgm:4.2.3-2-ubuntu22.04'

   does not exist on NGC (verified 2026-05-21 via 'docker manifest inspect'

   → 404). Bump to 4.5.1-1-ubuntu22.04, the only resolvable 4.x tag.

2. DCGM 4.5+ relocated python bindings from /usr/local/dcgm/bindings/python3/

   to /usr/share/datacenter-gpu-manager-4/bindings/python3/. The previous

   COPY would silently copy zero files under the new pin. Switch the source

   path to the 4.5+ location.

3. NGC's DCGM 4.5+ runtime image ships pydcgm with DcgmGroup.py:20 doing

   'import logger' — but logger.py lives in DCGM's source tree under

   testing/python3/ and is NOT packaged. Without a shim every DcgmGroup

   construction raises ModuleNotFoundError. Add a 10-line stdlib-logging

   adapter at components/power_agent/logger.py and COPY it into

   /opt/dcgm/python/logger.py during the runtime stage.

This unblocks 'docker build -f components/power_agent/Dockerfile' on a

fresh clone (verified locally via 'docker buildx build --build-arg

DCGM_IMAGE=...4.5.1-1-ubuntu22.04' against viking-prod-216 on 2026-05-21,

image pushed to ttl.sh/dynamo-pa-kaim-dcgm45-v2:24h and used by the

Path-B live test on aks-a100b-22138447-vmss000000).

Refs: PR #9790 review, Power Agent live-test findings #1/#2/#6.
Signed-off-by: Kai Ma <kaim@nvidia.com>
tmonty12 pushed a commit that referenced this pull request Jun 8, 2026
Signed-off-by: Kang Zhang <kangz@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
nnshah1 added a commit that referenced this pull request Jun 10, 2026
Address graham-code-review feedback on PR #10351:

- Drop the secondary `owners` map; store `Owner = (instance_id,
  lora_slug)` inline with each entry value. One lock, one source of
  truth, no nested-write-lock hazard, no two-map sync risk.
- `register` takes `&Owner` (one clone inside, not per-file).
- Panic on collision: re-registering the same (slug, suffix, filename)
  with a different owner is a programming error (two attaches of the
  same model+suffix in one process would let detach-#1 wipe files
  detach-#2 still needs). Same-owner re-register is fine and just
  updates the path.
- Doc + local var naming aligned on `instance_id` to match
  `local_model.rs`'s existing usage (the value populates
  `DiscoveryInstance::Model.instance_id`).
- Tests: collision panic + same-owner update path coverage.

Signed-off-by: nnshah1 <neelays@nvidia.com>
Broduker pushed a commit to Broduker/dynamo that referenced this pull request Jun 12, 2026
…i-dynamo#10124)

Signed-off-by: Kang Zhang <kangz@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: shenls <shenlinshan@kanzhun.com>
Broduker pushed a commit to Broduker/dynamo that referenced this pull request Jun 12, 2026
…i-dynamo#10124)

Signed-off-by: Kang Zhang <kangz@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: shenls <shenlinshan@kanzhun.com>

This branch was previously deployed

1 inactive deployment
GITLAB — 6104b6c8 Deployed Mar 4, 2025 by nvda-mesharma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants