Repository navigation
feat(epp): run custom selection services through standard bootstrap - #12720
Merged
Merged
Conversation
Contributor
|
🔗 Commit SHA: f0ac559 | Docs | Datadog PR Page | Give us feedback! |
ishandhanani
marked this pull request as ready for review
August 6, 2026 15:43
ishandhanani
force-pushed
the
idhanani/dyn-3775-python-frontend-policy
branch
from
August 6, 2026 16:09
78872d0 to
7102393
Compare
athreesh
approved these changes
Aug 6, 2026
An error occurred while trying to automatically change base from
idhanani/dyn-3712-native-worker-selection-api
to
main
August 7, 2026 01:39
ishandhanani
force-pushed
the
idhanani/dyn-3775-python-frontend-policy
branch
from
August 7, 2026 20:58
2f09560 to
bd9a4b9
Compare
ishandhanani
changed the base branch from
idhanani/dyn-3712-native-worker-selection-api
to
main
August 7, 2026 21:11
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
ishandhanani
force-pushed
the
idhanani/dyn-3775-python-frontend-policy
branch
from
August 7, 2026 21:22
bd9a4b9 to
f9229f5
Compare
Contributor
Author
|
/ok-to-test f9229f5 |
Contributor
WalkthroughThe EPP runner moved into reusable library code. The binary now invokes the crate-level runner, and custom worker selection passes a prebuilt ChangesEPP runner integration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Comment |
Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Contributor
Author
|
/ok-to-test f0ac559 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the existing Rust EPP process bootstrap into the
dynamo-ext-proclibrary and exposes it as a reusable runner. This lets custom linked policies pass a prebuiltSelectionServicewithout copying Dynamo's TLS, health, metrics, discovery, readiness, or server setup.CLOSES: DYN-3775
How This Was Implemented
run()andrun_with_selection_service(...)functions.dynamo-ext-procas a seven-line binary that calls the same default runner.EppRouter::from_selection_serviceconstructor in standalone EPP mode.Walkthrough
Mental model
The stock and custom binaries now differ only in how the selection service is supplied. Both enter the same process bootstrap and the same ext-proc request path.
flowchart LR D["Stock binary"] --> R["run()"] P["Custom policy crate"] --> S["Prebuilt SelectionService"] S --> C["run_with_selection_service()"] R --> B["Standard EPP bootstrap"] C --> B B --> E["EppRouter"] E --> X["ExtProcServer"]State and ordering
run()preserves the existing environment-driven mode selection: standalone mode builds the default embedded selector, while Dynamo runtime mode uses discovery.run_with_selection_service(...)explicitly selects standalone mode and moves the caller-owned service intoEppRouter; callers do not need to setDYN_EPP_MODEfor the custom path.Request lifecycle
Startup still initializes tracing, health reporting, metrics, standalone pod discovery or Dynamo discovery, readiness mirroring, TLS, and the ext-proc server in the existing order. After construction, requests follow the existing
EppRouterandSelectionServicepaths for tokenization, eligibility, scheduling, validation, accounting, reservations, and completion callbacks.Boundaries and limitations
This PR does not change the Python frontend,
HttpFrontend, worker-selection traits, default selection behavior, or request hot path. It adds no macro, runtime policy loading, C ABI, policy registry, or frontend configuration surface; custom policies remain statically linked into a Rust EPP image.Validation
cargo test -p dynamo-ext-proc --lib(117 passed)cargo check -p dynamo-ext-proc --all-targetscargo clippy -p dynamo-ext-proc --all-targets -- -D warningscargo fmt --all -- --checkpre-commit run --files deploy/inference-gateway/ext-proc/Cargo.toml deploy/inference-gateway/ext-proc/src/bin/dynamo-ext-proc.rs deploy/inference-gateway/ext-proc/src/lib.rs deploy/inference-gateway/ext-proc/src/runner.rs docs/fern/pages/developer-guide/advanced-customizations/custom-worker-selection.mdfern checkfern docs broken-linksSummary by CodeRabbit
New Features
Documentation