Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .agents/skills/pr-monitor/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,17 @@ If the branch does not exist, full CI has not been triggered. Common reasons:

1. **Awaiting approval**: An NVIDIA maintainer needs to comment `/ok to test <commit_sha>` on the PR to create the branch and trigger full CI. This applies to both fork PRs and internal PRs from authors not yet in the approval list.
2. **DCO failure**: Commits are not signed (`Signed-off-by` line missing). Check for a DCO bot comment. Fix: author signs their commits (see `DCO.md`).
3. **Draft PR**: Some checks may not run until marked ready for review.
3. **Unverified commit signature (eligible fork automatic approval)**: The automatic `/ok to test` flow requires GitHub to report every PR commit as `Verified`. A DCO sign-off alone does not meet this requirement. This applies only after the PR has an automatic approval path; signing commits does not create that path. Check the workflow's unsigned-commit comment or inspect `.commit.verification` for every PR commit; sign each unverified commit, then push again. A maintainer can manually review the current head and comment `/ok to test <sha>` when automatic approval is unavailable.
4. **Draft PR**: Some checks may not run until marked ready for review.

For a fork PR that is otherwise eligible for automatic approval, check every commit's
verification result:

```bash
gh api --paginate "repos/ai-dynamo/dynamo/pulls/$PR_NUMBER/commits?per_page=100" --jq '.[].sha' | while read -r sha; do
gh api "repos/ai-dynamo/dynamo/commits/$sha" --jq '"\(.sha[0:7]) verified=\(.commit.verification.verified) reason=\(.commit.verification.reason)"'
done
```

**Verify which workflows actually ran** against the PR's HEAD commit:

Expand Down Expand Up @@ -204,6 +214,7 @@ Synthesize into a concise report:
**If full CI not triggered:**
- "Full CI awaiting approval — an NVIDIA maintainer needs to comment `/ok to test <sha>` to create the `pull-request/$PR_NUMBER` branch."
- "DCO check failed — commits need to be signed. See DCO.md."
- "Eligible fork automatic approval is blocked — every PR commit needs a cryptographic signature that GitHub reports as `Verified`; DCO sign-off alone is insufficient."
- "Draft PR — some checks may not run until marked ready for review."
- Note which lightweight checks passed/failed.

Expand All @@ -225,6 +236,8 @@ Synthesize into a concise report:
**Next steps** — concrete actions ordered by priority:
- "An NVIDIA maintainer should comment `/ok to test <sha>`" if full CI hasn't triggered
- "Sign your commits with `git commit --amend -s`" for DCO failures
- "Sign and rewrite every unverified fork-PR commit, then push" when eligible automatic approval is blocked by commit verification
- "Ask a maintainer to review the current head and comment `/ok to test <sha>`" when automatic approval is unavailable
- "Fix X in file Y" for code failures
- Re-run command for infra flakes: `gh run rerun $RUN_ID --repo ai-dynamo/dynamo --failed`
- "No action needed — CI is green" if everything passed
Expand Down
7 changes: 6 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,18 @@ cargo fmt --all && cargo clippy --workspace
`style`, and `build`.
- PR descriptions must include `Summary` and `Validation`.
- Sign every commit with DCO: `git commit -s`.
- For fork PRs that qualify for automatic trusted-CI approval, every commit must have a
cryptographic signature that GitHub reports as `Verified`; a DCO sign-off alone does not
satisfy this requirement. Signing commits does not itself qualify a PR for automatic approval;
a maintainer can manually approve the current head with `/ok to test <sha>`.
- Do not hand-edit the root `CODEOWNERS` — it is generated. To change review
routing, edit `.github/codeowners/areas.yaml` and regenerate; CI gates 100%
coverage and `CODEOWNERS`↔`areas.yaml` drift. See
`.github/codeowners/README.md` (use `who_owns.py` to check who reviews a path).
- Full CI on a PR runs only after a maintainer comments `/ok to test <sha>` with the short
SHA of the latest commit; copy-pr-bot then creates the `pull-request/N` branch that
triggers it. Fix failures before requesting human review.
triggers it. For an eligible fork PR, the automatic approval flow posts that command only
after every PR commit is GitHub-verified. Fix failures before requesting human review.
- Architecture changes require a Dynamo Enhancement Proposal (DEP), filed as a GitHub
issue on `ai-dynamo/dynamo` with `dep:*` labels (the `dep-create` skill automates this).

Expand Down
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,15 @@ Or view the source: [`docs/contribution-guide.md`](docs/fern/pages/community/con

Dynamo requires all contributions to be signed off with the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). This certifies that you have the right to submit your contribution under the project's [Apache 2.0 license](https://github.com/ai-dynamo/dynamo/blob/main/LICENSE).

For pull requests from forks that qualify for automatic trusted-CI approval, every commit must
have a cryptographic signature that GitHub reports as `Verified`. A DCO sign-off from
`git commit -s` does not sign a commit. Configure [GitHub-supported commit
signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits),
sign every commit in the PR, and confirm that GitHub marks each one as `Verified`. If any
commit is not verified, the automatic `/ok to test` comment is not posted.

Signing commits does not by itself qualify a fork pull request for automatic approval. When
automatic approval is unavailable, a maintainer can review the current head and comment
`/ok to test <sha>` to start CI.

By contributing, you agree that your contributions will be licensed under the [Apache 2.0 License](https://github.com/ai-dynamo/dynamo/blob/main/LICENSE).
10 changes: 7 additions & 3 deletions docs/fern/pages/community/contributing/contribution-flow.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,13 @@ or multiple major components require a
<Step title="Complete automated review and CI">
Respond to actionable automated review comments and fix failing checks.

For external contributions, a maintainer might need to authorize CI for the latest commit. If
requested, wait for a maintainer to trigger the tests rather than repeatedly pushing unchanged
commits.
For a fork pull request, automatic trusted-CI approval requires the contributor or latest
branch update to meet repository approval criteria and every PR commit to have a cryptographic
signature that GitHub reports as `Verified`.
`git commit -s` adds a DCO sign-off but does not add a cryptographic signature. Signing does
not itself qualify a pull request for automatic approval. When automatic approval is
unavailable, a maintainer can review the current head and comment `/ok to test <sha>` to start
CI. Wait for that action rather than repeatedly pushing unchanged commits.

<Info>
You are responsible for understanding and validating all submitted code, including code
Expand Down
20 changes: 18 additions & 2 deletions docs/fern/pages/community/contributing/dco-and-licensing.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,23 @@ git log --format='%h %s%n%(trailers:key=Signed-off-by)' upstream/main..HEAD

Each listed commit must have a sign-off trailer.

## Repair the Latest Commit
## Automatic Trusted CI for Fork Pull Requests

For a fork pull request that qualifies for automatic trusted-CI approval, GitHub must report every
commit in the pull request as `Verified`. A DCO sign-off from `git commit -s` does not add a
cryptographic signature. Configure [GitHub-supported commit
signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
and use that configuration whenever you create, amend, or rebase a commit.

Open the pull request's **Commits** tab and confirm that GitHub shows `Verified` for every commit.
If any commit is not verified, the automatic `/ok to test` comment is not posted. Signing commits
does not by itself qualify a pull request for automatic approval. When automatic approval is
unavailable, a maintainer can review the current head and comment `/ok to test <sha>` to start CI.

The repair commands below add DCO sign-offs. To add or preserve a cryptographic signature while
rewriting a commit, include `--gpg-sign` after configuring commit signing.

## Repair the Latest DCO Sign-off

If only the latest commit is missing its sign-off, amend it:

Expand All @@ -64,7 +80,7 @@ git push --force-with-lease
Amending changes the commit SHA. Use `--force-with-lease`, not `--force`, when updating a published
branch.

## Repair Multiple Commits
## Repair Multiple DCO Sign-offs

Start an interactive rebase that includes the unsigned commits:

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ that determines whether you should open an issue first, see [Contribution Flow](
Use `pre-commit run --all-files` when you need to validate the entire repository.
</Step>

<Step title="Configure DCO sign-off">
<Step title="Configure DCO sign-off and commit signing">
Configure the name and email that should appear in your commits:

```bash
Expand All @@ -72,6 +72,13 @@ that determines whether you should open an issue first, see [Contribution Flow](
git commit -s -m "fix(component): describe the change"
```

For automatic trusted-CI approval of a fork pull request, configure
[GitHub-supported commit signing](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
too. GitHub must show every commit in the pull request as `Verified`; `git commit -s` adds a
DCO sign-off but does not add a cryptographic signature. Signing does not itself qualify a
pull request for automatic approval. A maintainer can instead review the current head and
comment `/ok to test <sha>` to start CI.

For the full requirement and repair instructions, see
[DCO and Licensing](dco-and-licensing.md).
</Step>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Dynamo 拥有 200 多位外部贡献者、220 多个已合并的社区 PR,并
2. 对于 ≥100 行的变更或新功能,请先[创建 issue](https://github.com/ai-dynamo/dynamo/issues/new?template=contribution_request.yml)
3. 创建分支:`git checkout -b yourname/fix-router-timeout`
4. 修改代码,运行 `pre-commit run`
5. 使用 DCO sign-off 提交:`git commit -s -m "fix: description"`
5. 使用 DCO sign-off 提交:`git commit -s -m "fix: description"`;对于符合自动受信任 CI 批准条件的 fork PR,每个提交还必须包含 GitHub 显示为 `Verified` 的加密签名。DCO sign-off 不会添加加密签名,签名本身也不会使 PR 获得自动批准资格
6. 打开一个面向 `main` 的 PR

---
Expand Down Expand Up @@ -221,7 +221,7 @@ pre-commit install

4. **处理 Code Rabbit Review** — 回复自动化 Code Rabbit 建议,包括 nitpick。

5. **触发 CI 测试** — 对于外部贡献者,维护者必须评论 `/ok to test COMMIT-ID` 才能运行完整 CI 套件,其中 `COMMIT-ID` 是你最新提交的短 SHA。请求人工审阅前,请修复所有失败的测试。
5. **触发 CI 测试** — 对于符合自动批准条件的 fork PR,每个 PR 提交都必须包含 GitHub 显示为 `Verified` 的加密签名。`git commit -s` 只会添加 DCO sign-off,不会添加加密签名,签名本身也不会让 PR 获得自动批准资格。如果自动批准不可用,维护者可以审阅当前 head 并评论 `/ok to test COMMIT-ID` 以启动 CI,其中 `COMMIT-ID` 是最新提交的短 SHA。请求人工审阅前,请修复所有失败的测试。

6. **请求审阅** — 将批准你 issue 的人员添加为 reviewer。根据修改的文件,查看 [CODEOWNERS](https://github.com/ai-dynamo/dynamo/blob/main/CODEOWNERS) 了解必需 approver。

Expand Down Expand Up @@ -399,6 +399,12 @@ git commit -s -m "fix: your descriptive message"

**DCO 检查失败?** 请参阅我们的 [DCO 故障排除指南](https://github.com/ai-dynamo/dynamo/blob/main/DCO.md),按步骤修复。

### Fork PR 的自动 CI 签名

对于符合自动受信任 CI 批准条件的 fork PR,GitHub 必须将 PR 中的每个提交显示为 `Verified`。DCO sign-off 不会添加加密签名。请按照 [GitHub 提交签名说明](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) 配置签名,并在创建、修订或 rebase 提交时使用该配置。签名本身不会让 PR 获得自动批准资格。

在 PR 的 **Commits** 标签页确认每个提交都显示为 `Verified`。如果任何提交未验证,系统不会自动发布 `/ok to test` 评论。如果自动批准不可用,维护者可以审阅当前 head 并评论 `/ok to test COMMIT-ID` 来启动 CI,其中 `COMMIT-ID` 是最新提交的短 SHA。

### 许可证

通过贡献,你同意你的贡献将依据 [Apache 2.0 License](https://github.com/ai-dynamo/dynamo/blob/main/LICENSE) 授权。
Expand Down
Loading