Repository navigation
refactor(request-trace): reuse object-store S3 client [DYN-3844] - #13002
Merged
Merged
Conversation
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Contributor
ishandhanani
approved these changes
Aug 11, 2026
Contributor
WalkthroughThe S3 request trace sink now uses the shared ChangesS3 object-store migration
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
Signed-off-by: PeaBrane <yanrpei@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-configandaws-sdk-s3client with theobject_storeS3 client already used bydynamo-llm.application/gzip, each request has a 30-second timeout, and the full operation is bounded to 90 seconds across three attempts.request-trace-s3feature while removing its two direct AWS SDK dependency edges.Dependency Footprint
56 production packages removed, 0 added.
aws-configandaws-sdk-s3are no longer reachable.object_storewas already present, so the replacement adds no packages.The lockfiles may retain inactive AWS package records, but identical
cargo tree --lockedcomparisons confirm that they are not reachable from these production graphs and are not compiled as part of them.Validation
cargo test -p dynamo-llm --no-default-features --features request-trace-s3 request_trace::s3_sink --lib— 7 passed, including an in-memory upload round trip that verifies the object body and content type.cargo treecomparisons forx86_64-unknown-linux-gnuconfirmed thataws-configandaws-sdk-s3are unreachable from thedynamo-llmand production Python graphs; the production graphs remove 56 packages and add none.cargo clippy -p dynamo-llm --no-default-features --features request-trace-s3 --lib -- -D warnings.cargo clippy --no-default-features -- -D warningsandcargo fmtfromlib/llm.fern checkandfern docs broken-links.No live AWS environment was used for an end-to-end upload test; the local test exercises the new
ObjectStore::put_optspath without external credentials or infrastructure.Summary by CodeRabbit
AWS_REGION, thenAWS_DEFAULT_REGION, thenus-east-1.