Repository navigation
fix(agent): classify Responses tool outputs as tool results - #13819
Conversation
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test 6b88229 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughOpenAI Responses input-trigger classification now maps all supported tool-output item variants to ChangesResponses tool-output classification
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change classifies explicit Responses tool outputs as tool results while preserving existing classifications for other item types; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the background, affected tool-output variants, intended behavior, unchanged behavior, tests, and validation commands. It does not include the required Related Issues section or identify where the reviewer should start. Resolution Add the required Related Issues section and select either a real issue reference, such as Closes
Comment |
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test eecd728 |
|
The CI failure is unrelated to this PR’s code changes. Both the amd64 and arm64 builds completed successfully, including the image manifest merge. The job failed afterward during SBOM export because the remote BuildKit connection timed out ( |
Signed-off-by: xianlubird <xianlubird@gmail.com>
|
/ok to test cf5df90 |
|
The failing KV-router test ( |
|
/ok to test b9448c5 |
Background
#12787 introduced provider-aware input-trigger classification for agent request traces, but intentionally left non-function Responses tool outputs as a follow-up. As a result, computer, shell, apply-patch, tool-search, and custom tool results are currently classified as
otherinstead oftool_result. This loses the causal turn type in request traces and in worker-selection policies that consume agent context.Summary
InputTrigger::ToolResultValidation
cargo fmt --all -- --checkcargo test -p dynamo-llm --lib input_trigger --no-default-featurescargo test -p dynamo-llm --lib request_trace --no-default-features -- --skip tool_relaycargo clippy -p dynamo-llm --lib --no-default-features -- -D warningsgit diff --checkSummary by CodeRabbit
Bug Fixes
Tests