Repository navigation
fix(frontend): propagate sglang backend errors with reason (4xx where settable) #14729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jokerhaos
wants to merge
1
commit into
ai-dynamo:main
Choose a base branch
from
jokerhaos:public/sglang-disagg-error-propagation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For streaming requests with the default configuration, this raise still becomes an annotated backend-error frame in
PythonAsyncEngine; the HTTP service commits 200 immediately whenDYN_HTTP_PRE_COMMIT_ERROR_PEEK_MSis unset (its documented default). Thus an over-context or queue rejection before the first output is returned as an SSE error after HTTP 200, not the promised 400/429.🤖 AI Fix
Enable pre-commit inspection for these request-validation errors by making the HTTP error-peek path active by default, or otherwise add a pre-stream error channel that can set the HTTP status before the SSE response is committed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, and thanks — this is correct, and I had it wrong in the original PR description.
In default streaming (
DYN_HTTP_PRE_COMMIT_ERROR_PEEK_MSunset) the HTTP service commits 200 immediately (lib/llm/src/http/service/openai.rs~2966: "Env var unset → skip peek, commit HTTP 200 immediately … Backend errors will surface as SSE error frames via monitor_for_disconnects"), so a pre-streamraisehere surfaces as 200 + SSE error event, not a 4xx. The 400/429 status is set only where the HTTP layer can still set it: non-streaming requests (raise routed tofrom_http_error→StatusCode), and streaming with the pre-commit error peek enabled (check_for_backend_errorpeeks the first non-annotation event before commit).So this PR's actual delivery is: the reason reaches the client on all paths (was an opaque 500 / bare SSE frame with no reason), and the 400/429 HTTP status is honoured only on non-streaming and peek-on streaming. I've corrected the code comment and the PR body / commit message to state the default-streaming behaviour explicitly, and flagged "enable the pre-commit error peek by default for these validation errors" as a follow-up — it's a Rust HTTP-service default change, which deliberately stays out of scope here (it's in DEP #14354's territory). Happy to open that follow-up separately if maintainers want it.