Repository navigation
test(sidecar): isolate vLLM unit contracts and fix regressions - #15089
Closed
JulienDarve wants to merge 12 commits into
Closed
JulienDarve wants to merge 12 commits into
JulienDarve wants to merge 12 commits into
Conversation
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
JulienDarve
changed the base branch from
jdarve/sidecar-cpu-wire
to
jdarve/sidecar-shared-unit-harness
September 22, 2026 22:23
JulienDarve
commented
Sep 22, 2026
JulienDarve
left a comment
Contributor
Author
There was a problem hiding this comment.
@dcoapp recheck
Contributor
Author
|
/ok to test b3ab163 |
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Closed
JulienDarve
force-pushed
the
jdarve/sidecar-shared-unit-harness
branch
2 times, most recently
from
September 29, 2026 22:11
f6f9063 to
6d572dd
Compare
Contributor
Author
|
Implemented here instead: #15243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add isolated coverage for shared sidecar configuration, deadlines and typed errors, plus vLLM conversion, discovery metadata, LoRA identity and Worker configuration. Shared production code runs once; new backend units are vLLM-only.
Keep the three supported behavior fixes with their regressions: hide system-only stop reasons, prevent successful handoff from aborted prefill, and consume engine-supplied effective attention block size with legacy fallback.
Second PR in the stack: #14879 → #15089 → #15091. Preserve #14879’s SGLang coverage and all five legacy wire tests until their replacements arrive in #15091. Only vLLM’s before-start cleanup assertions move into isolated units.
Coverage, retained assertions, deviations and historical evidence are recorded in COVERAGE.md, UNITS.md and DEVIATIONS.md.
Validation
At b3ab163, on refreshed foundation 286d6fd:
Current-head GitHub CI is pending. Stock vLLM 0.29’s effective-block-size producer limitation remains upstream; this PR adds no native-engine tests.
Linear: https://linear.app/nvidia/issue/DIS-2942