Repository navigation
fix(tests): include native sidecars in deployment diagnostics - #16288
Merged
julienmancuso merged 3 commits intoNov 5, 2026
Merged
julienmancuso merged 3 commits into
julienmancuso merged 3 commits into
Conversation
panpan0000
temporarily deployed
to
external_collaborator
October 13, 2026 06:27 — with
GitHub Actions
Inactive
panpan0000
temporarily deployed
to
external_collaborator
October 13, 2026 06:27 — with
GitHub Actions
Inactive
Contributor
|
👋 Hi panpan0000! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
panpan0000
temporarily deployed
to
external_collaborator
October 13, 2026 11:27 — with
GitHub Actions
Inactive
julienmancuso
approved these changes
Nov 3, 2026
Contributor
|
@panpan0000 could you rebase ? |
Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>
panpan0000
force-pushed
the
codex/16287-sidecar-test-diagnostics
branch
from
November 4, 2026 05:33
f7c12c9 to
75bd463
Compare
panpan0000
temporarily deployed
to
external_collaborator
November 4, 2026 05:33 — with
GitHub Actions
Inactive
Contributor
Author
|
@julienmancuso done, thanks for reminder |
Contributor
|
/ok to test 75bd463 |
julienmancuso
enabled auto-merge (squash)
November 4, 2026 14:42
panpan0000
temporarily deployed
to
external_collaborator
November 5, 2026 03:49 — with
GitHub Actions
Inactive
Contributor
Author
|
update branch to resolve old code CI issue |
panpan0000
temporarily deployed
to
external_collaborator
November 5, 2026 03:57 — with
GitHub Actions
Inactive
Contributor
|
/ok to test ed030ac |
ishandhanani
added a commit
to ishandhanani/dynamo
that referenced
this pull request
Nov 5, 2026
Fifth upstream merge for the split v2 PR: the four commits past 20c5f11, no conflicts, no router-owned path. - ai-dynamo#18116 pass plugin selectors to the transcription router: lib/llm/src/discovery/watcher.rs (auto-merged). - ai-dynamo#17691 DynamoDB registration store for the Global Discovery Service: lib/global-discovery-service, root Cargo.toml workspace deps, Cargo.lock. - ai-dynamo#16288 deployment diagnostics tests, ai-dynamo#16723 helm KAI queue wait: outside the router. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deployment readiness diagnostics omit native sidecars because they only inspect regular-container statuses. Include init-container statuses in pod status reporting and per-restart previous-log capture, including before regular containers start. Reuse the existing log capture and restart deduplication.
Closes #16287.
Validation
python -m pytest -q tests/deploy/test_dgd_utils.py: 21 passed.git diff --checkpassed.Validation uses mocked Kubernetes API responses; no live cluster test was run.
Summary by CodeRabbit