Repository navigation
Conversation
|
👋 Hi Bafoleco! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Configure the session-affinity capacity lib/runtime/src/config/environment_names.rs, lib/llm/src/session_affinity/mod.rs, lib/llm/src/session_affinity/tests.rs, docs/fern/pages/developer-guide/knowledge-base/modular-components/router/configuration-and-tuning.md |
Adds and documents DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIES. The configuration helper accepts positive integer values, preserves the default when unset, and returns errors for invalid values or lookup failures. Tests cover the default, invalid values, and admission at capacity. |
Use environment-based configuration lib/llm/src/session_affinity/coordinator.rs, lib/llm/src/kv_router/embedded.rs |
Both coordinator paths obtain session-affinity configuration from config_from_env and propagate errors. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Merge Risk: 
Minimal · up to acd22
-
The configurable session-affinity limit appears ready to merge after normal checks; no specific blocking issue is established.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Title check
-
Explanation
The title "feat(router): make session affinity capacity configurable" matches the main change. The PR adds the DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIES environment variable, which sets the per-table entry limit (default 65536) for session affinity. The title is short, specific, and follows a conventional-commit style.
Full details: Description check
-
Explanation
The pull request description includes the change summary, validation results, and the required Related Issues section with a valid issue reference. It does not include the template's "Where should the reviewer start?" section, but the description is otherwise complete and on topic.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 5 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Signed-off-by: Bay Foley-Cox <bayfoleycox@gmail.com>
Signed-off-by: Bay Foley-Cox <bayfoleycox@gmail.com>
Signed-off-by: Bay Foley-Cox <bayfoleycox@gmail.com>
…sses Signed-off-by: Bay Foley-Cox <bayfoleycox@gmail.com>
Signed-off-by: Bay Foley-Cox <bayfoleycox@gmail.com>
5d3f33f to
c23ae7a
Compare
Summary
Adds
DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIESto configure capacity per affinity table. We've found this change was necessary as very long large deployments with long L3 backed TTLs can exceed 65k sessions.Validation
cargo test -p dynamo-llm --no-default-features --lib session_affinity::tests --lockedpassed (35 tests).Related Issues
Closes #17363
Summary by CodeRabbit
DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIESto a positive integer; the default is 65,536.