Skip to content

chore(codeowners): add EPP team as co-owner of router and frontend paths it depends on - #18145

Merged
dagil-nvidia merged 1 commit into
mainfrom
atchernych/dep-1332-epp-codeowners
Nov 5, 2026
Merged

dagil-nvidia merged 1 commit into
mainfrom
atchernych/dep-1332-epp-codeowners

Conversation

@atchernych

@atchernych atchernych commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Overview

The EPP (deploy/inference-gateway/ext-proc/) runs the KV router in-process and shares behavior with the frontend. The router team already co-owns the EPP directory, but the EPP code owners team owned none of the router or frontend code the EPP depends on, so a change there could alter EPP behavior without requesting EPP review. This PR adds the EPP team as a co-owner of 12 of those paths and keeps every current owner.

Key Changes

No code changes: 46 lines of ownership policy in .github/codeowners/areas.yaml, plus the regenerated CODEOWNERS. Each path below gains dynamo-epp-codeowners.

Router paths (previously router only):

Path What the EPP uses there
lib/kv-router/src/services/selection/* The selection-service API that standalone EPP mode is built on: SelectionService, CatalogReconciler, and the request and error types. Top-level files only; the selection core in core/ stays router-only.
lib/kv-router/src/scheduling/config.rs KvRouterConfig, RouterConfigOverride, and the DYN_ROUTER_* environment variables the EPP reads
lib/kv-router/src/plugins/registry.rs RouterPluginRegistry, which the EPP and custom EPP builds take
lib/router-plugins/builtin/src/lib.rs default_registry() and with_defaults()
lib/llm/src/kv_router/prefill_router/query.rs reserve_prefill_worker and PrefillReservation, the Runtime EPP's prefill booking
lib/llm/src/kv_router/routing_load.rs ManagedKvRouter, the Runtime EPP's decode router
lib/llm/src/kv_router/README.md The selection-inputs table. The module's AGENTS.md asks that each new input be checked against the Runtime EPP.
examples/router/custom-policy-example/epp/ A workspace crate that calls dynamo_ext_proc::run

Frontend and runtime paths:

Path Owners before What it holds
lib/llm/src/entrypoint.rs frontend RouterConfig: router mode, KV router config, load thresholds, and session affinity, the settings the EPP sets for its own router
lib/llm/src/discovery/worker_monitor.rs runtime LoadThresholdConfig and LoadThresholdHandle; the Runtime EPP passes its decode router's handle to its PrefillRouter
lib/llm/src/http/service/error.rs frontend The frontend's HTTP error types and status mapping
lib/llm/src/http/service/busy_threshold.rs frontend, kv-memory The endpoint that reads and sets per-model busy thresholds

Two effects to weigh:

  • Any one owner's approval satisfies the code-owner check, so one EPP approval now covers these 12 paths, as one router approval already covers the EPP directory.
  • From 2026-08-06 to 2026-11-04, 71 PRs touched these paths and 57 of them did not touch the EPP, so the EPP team gets about 4 more review requests a week.

Validation

  • Strict ownership gate: 7,775 of 7,775 files explicitly owned; the regenerated CODEOWNERS changes by the expected 12 lines.
  • who_owns.py: each path resolves to its previous owners plus dynamo-epp-codeowners; selection/core/, prefill_router/mod.rs, and entrypoint/ keep their previous owners.
  • CODEOWNERS matcher and generator suite: 158 passed.

Issues and Ongoing Work

Pull Request Checklist
  • I used Dynamo's /pr-checklist skill.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated ownership coverage across selected routing, runtime, frontend, and plugin areas, and expanded coverage for several related components.
    • These changes affect how project updates are assigned for review and do not alter application behavior or add user-facing features.

…ths it depends on

The EPP (deploy/inference-gateway/ext-proc) runs the KV router in-process
and shares behavior with the frontend, but the EPP code owners team owned
none of that code, so a change there could alter EPP behavior without
requesting EPP review.

Add the EPP team to twelve paths and keep every current owner: the
selection-service API (top-level files only; core/ stays router-only), the
router config and plugin registry, the Runtime EPP's prefill booking and
decode router, the kv_router README's selection-inputs table, the
custom-policy EPP example, and four frontend and runtime files.

Refs DEP-1332

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
@atchernych
atchernych requested review from a team as code owners November 4, 2026 23:16
@github-actions github-actions Bot added the chore label Nov 4, 2026
@coderabbitai

coderabbitai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The pull request adds EPP as a co-owner for selected paths in .github/codeowners/areas.yaml and CODEOWNERS. The rules cover router, runtime, frontend, plugin, service, and example files.

Changes

EPP ownership rules

Layer / File(s) Summary
Shared EPP ownership rules
.github/codeowners/areas.yaml, CODEOWNERS
EPP is added as a co-owner for selected router, runtime, frontend, plugin, service, README, query, and example paths. The selection rule keeps core/ router-only, and the busy-threshold rule retains its existing owners while adding EPP.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to 63297

No actionable merge-blocking risk remains in this ownership-only change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: adding the EPP team as a co-owner for dependent router and frontend paths.
Description check Passed The description includes all required sections, explains the purpose and affected paths, documents validation results, identifies ongoing work and the linked issue, and includes the completed checklis…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description includes all required sections, explains the purpose and affected paths, documents validation results, identifies ongoing work and the linked issue, and includes the completed checklist.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between b9ba191 and 63297dc.

Files selected for processing: 2
  • .github/codeowners/areas.yaml
  • CODEOWNERS

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

@hutm
hutm self-requested a review November 4, 2026 23:52
@devin-ai-integration

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 41932421723 (attempt 1) on 63297dcb35

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 41932421723. Updated on every full-CI run of this PR.

@dagil-nvidia
dagil-nvidia merged commit f01ff2b into main Nov 5, 2026
120 checks passed
ishandhanani added a commit to ishandhanani/dynamo that referenced this pull request Nov 6, 2026
Twenty-six upstream commits. Conflicts in eight paths, resolved into the
owner crates; everything else merged by path.

- ai-dynamo#17910 strict boolean worker flags: lib/router/scheduler/src/selection/types.rs (kernel WorkerRequest and WorkerPatchRequest take strict_bool on is_eagle and engine_owned_mm_identity; carried by rename detection), lib/bindings/python/tests/test_kv_bindings.py.
- ai-dynamo#18240 configurable session-affinity entry limit: lib/llm/src/session_affinity/mod.rs reads SessionAffinityConfig and MAX_SESSION_AFFINITY_ENTRIES from dynamo_session_affinity::host (the host contract now exports the entry limit), coordinator.rs and kv_router/embedded.rs build the table through affinity_config; frontend args, env names, docs and Python tests auto-merged.
- ai-dynamo#18145 EPP co-ownership: .github/codeowners/areas.yaml globs re-pointed to the moved files (lib/router/kv-router/src/plugins/registry.rs; lib/router/kv-router/src/scheduling/config.rs plus the kernel slice lib/router/scheduler/src/config.rs; the pre-split services/selection top level as lib/router/scheduler/src/selection/*, lib/router/kv-router/src/services/selection/* and lib/router/session-affinity/src/lib.rs, core/ stays router-only); the lib/llm, router-policies and example globs auto-merged; CODEOWNERS regenerated.
- ai-dynamo#17708 nvtx in pre-merge CI: .github/workflows/pre-merge.yml gains "Run NVTX feature tests" after the stack's kv-router adapter and canonical replay steps and "Lint the NVTX feature" in rust-clippy; Cargo.toml profiling comment, pyproject.toml.
- ai-dynamo#17623 dependency bumps: lib/mocker/Cargo.toml adds zip next to the stack's fastrand; lib/llm/Cargo.toml utoipa-swagger-ui 10.0.2; the root, python-bindings and kvbm lockfiles taken from upstream and regenerated.
- ai-dynamo#17675 DynamoDB-backed global session affinity: lib/global-router, lib/global-frontend, new lib/global-router-store-dynamodb workspace member.
- ai-dynamo#18278 synthetic session prompts in replay: lib/mocker/src/replay/entrypoints.rs, lib/bindings/python/rust/llm/replay.rs, _core.pyi, components replay package and tests.
- ai-dynamo#16607 use-case docs refactor: docs/fern; multimodal-kv-routing.md moved to use-cases/image-understanding/vlm-performance-optimization/ and the stack's DYN_LOG directive (dynamo_scheduler, dynamo_admission, dynamo_worker_selection) carried to the new path.
- ai-dynamo#17706 NVTX ranges on the OpenAI HTTP path, ai-dynamo#17626 beam tool constraints, ai-dynamo#18015 MiniMax SSE keep-alive: lib/llm, auto-merged.
- ai-dynamo#18229 Velo in-place encoding: lib/runtime. ai-dynamo#17370 SGLang first-chunk logprobs: lib/generate-formats.
- ai-dynamo#17862 vLLM 0.33.0 bump: container, components, lib/sidecar/vllm, pyproject.
- ai-dynamo#18121, ai-dynamo#18154, ai-dynamo#18111 planner live retune; ai-dynamo#18234 Hunyuan reasoning defaults; ai-dynamo#17229 TRT-LLM KVBM removal: components, tests, bindings Python, docs.
- ai-dynamo#18069, ai-dynamo#18066 operator; ai-dynamo#18244 recipes; ai-dynamo#18210 batch docs; three automated community-events refreshes.

Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants