Repository navigation
chore(codeowners): add EPP team as co-owner of router and frontend paths it depends on - #18145
Conversation
…ths it depends on The EPP (deploy/inference-gateway/ext-proc) runs the KV router in-process and shares behavior with the frontend, but the EPP code owners team owned none of that code, so a change there could alter EPP behavior without requesting EPP review. Add the EPP team to twelve paths and keep every current owner: the selection-service API (top-level files only; core/ stays router-only), the router config and plugin registry, the Runtime EPP's prefill booking and decode router, the kv_router README's selection-inputs table, the custom-policy EPP example, and four frontend and runtime files. Refs DEP-1332 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Anna Tchernych <atchernych@nvidia.com>
|
No actionable comments were generated in the recent review. WalkthroughThe pull request adds EPP as a co-owner for selected paths in ChangesEPP ownership rules
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk:
|
✅ Dynamo PR CI passed — run 41932421723 (attempt 1) on
|
Twenty-six upstream commits. Conflicts in eight paths, resolved into the owner crates; everything else merged by path. - ai-dynamo#17910 strict boolean worker flags: lib/router/scheduler/src/selection/types.rs (kernel WorkerRequest and WorkerPatchRequest take strict_bool on is_eagle and engine_owned_mm_identity; carried by rename detection), lib/bindings/python/tests/test_kv_bindings.py. - ai-dynamo#18240 configurable session-affinity entry limit: lib/llm/src/session_affinity/mod.rs reads SessionAffinityConfig and MAX_SESSION_AFFINITY_ENTRIES from dynamo_session_affinity::host (the host contract now exports the entry limit), coordinator.rs and kv_router/embedded.rs build the table through affinity_config; frontend args, env names, docs and Python tests auto-merged. - ai-dynamo#18145 EPP co-ownership: .github/codeowners/areas.yaml globs re-pointed to the moved files (lib/router/kv-router/src/plugins/registry.rs; lib/router/kv-router/src/scheduling/config.rs plus the kernel slice lib/router/scheduler/src/config.rs; the pre-split services/selection top level as lib/router/scheduler/src/selection/*, lib/router/kv-router/src/services/selection/* and lib/router/session-affinity/src/lib.rs, core/ stays router-only); the lib/llm, router-policies and example globs auto-merged; CODEOWNERS regenerated. - ai-dynamo#17708 nvtx in pre-merge CI: .github/workflows/pre-merge.yml gains "Run NVTX feature tests" after the stack's kv-router adapter and canonical replay steps and "Lint the NVTX feature" in rust-clippy; Cargo.toml profiling comment, pyproject.toml. - ai-dynamo#17623 dependency bumps: lib/mocker/Cargo.toml adds zip next to the stack's fastrand; lib/llm/Cargo.toml utoipa-swagger-ui 10.0.2; the root, python-bindings and kvbm lockfiles taken from upstream and regenerated. - ai-dynamo#17675 DynamoDB-backed global session affinity: lib/global-router, lib/global-frontend, new lib/global-router-store-dynamodb workspace member. - ai-dynamo#18278 synthetic session prompts in replay: lib/mocker/src/replay/entrypoints.rs, lib/bindings/python/rust/llm/replay.rs, _core.pyi, components replay package and tests. - ai-dynamo#16607 use-case docs refactor: docs/fern; multimodal-kv-routing.md moved to use-cases/image-understanding/vlm-performance-optimization/ and the stack's DYN_LOG directive (dynamo_scheduler, dynamo_admission, dynamo_worker_selection) carried to the new path. - ai-dynamo#17706 NVTX ranges on the OpenAI HTTP path, ai-dynamo#17626 beam tool constraints, ai-dynamo#18015 MiniMax SSE keep-alive: lib/llm, auto-merged. - ai-dynamo#18229 Velo in-place encoding: lib/runtime. ai-dynamo#17370 SGLang first-chunk logprobs: lib/generate-formats. - ai-dynamo#17862 vLLM 0.33.0 bump: container, components, lib/sidecar/vllm, pyproject. - ai-dynamo#18121, ai-dynamo#18154, ai-dynamo#18111 planner live retune; ai-dynamo#18234 Hunyuan reasoning defaults; ai-dynamo#17229 TRT-LLM KVBM removal: components, tests, bindings Python, docs. - ai-dynamo#18069, ai-dynamo#18066 operator; ai-dynamo#18244 recipes; ai-dynamo#18210 batch docs; three automated community-events refreshes. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Overview
The EPP (
deploy/inference-gateway/ext-proc/) runs the KV router in-process and shares behavior with the frontend. The router team already co-owns the EPP directory, but the EPP code owners team owned none of the router or frontend code the EPP depends on, so a change there could alter EPP behavior without requesting EPP review. This PR adds the EPP team as a co-owner of 12 of those paths and keeps every current owner.Key Changes
No code changes: 46 lines of ownership policy in
.github/codeowners/areas.yaml, plus the regeneratedCODEOWNERS. Each path below gainsdynamo-epp-codeowners.Router paths (previously router only):
lib/kv-router/src/services/selection/*SelectionService,CatalogReconciler, and the request and error types. Top-level files only; the selection core incore/stays router-only.lib/kv-router/src/scheduling/config.rsKvRouterConfig,RouterConfigOverride, and theDYN_ROUTER_*environment variables the EPP readslib/kv-router/src/plugins/registry.rsRouterPluginRegistry, which the EPP and custom EPP builds takelib/router-plugins/builtin/src/lib.rsdefault_registry()andwith_defaults()lib/llm/src/kv_router/prefill_router/query.rsreserve_prefill_workerandPrefillReservation, the Runtime EPP's prefill bookinglib/llm/src/kv_router/routing_load.rsManagedKvRouter, the Runtime EPP's decode routerlib/llm/src/kv_router/README.mdAGENTS.mdasks that each new input be checked against the Runtime EPP.examples/router/custom-policy-example/epp/dynamo_ext_proc::runFrontend and runtime paths:
lib/llm/src/entrypoint.rsRouterConfig: router mode, KV router config, load thresholds, and session affinity, the settings the EPP sets for its own routerlib/llm/src/discovery/worker_monitor.rsLoadThresholdConfigandLoadThresholdHandle; the Runtime EPP passes its decode router's handle to itsPrefillRouterlib/llm/src/http/service/error.rslib/llm/src/http/service/busy_threshold.rsTwo effects to weigh:
Validation
CODEOWNERSchanges by the expected 12 lines.who_owns.py: each path resolves to its previous owners plusdynamo-epp-codeowners;selection/core/,prefill_router/mod.rs, andentrypoint/keep their previous owners.Issues and Ongoing Work
lib/router/:plugins/registry.rs,scheduling/config.rs, and theservices/selection/files. Whichever PR merges second updates those rows; the stale-glob gate flags them.Pull Request Checklist
/pr-checklistskill.🤖 Generated with Claude Code
Summary by CodeRabbit