Repository navigation
fix(recipes): restore Nemotron 3.5 Super VL benchmark defaults - #18334
Merged
krishung5 merged 1 commit intoNov 6, 2026
Merged
Conversation
Signed-off-by: milesial <milesial@users.noreply.github.com>
milesial
temporarily deployed
to
external_collaborator
November 6, 2026 18:17 — with
GitHub Actions
Inactive
milesial
temporarily deployed
to
external_collaborator
November 6, 2026 18:17 — with
GitHub Actions
Inactive
Contributor
|
👋 Hi milesial! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
|
/ok to test 600234a |
milesial
marked this pull request as ready for review
November 6, 2026 18:20
ynpandey-nv
approved these changes
Nov 6, 2026
krishung5
approved these changes
Nov 6, 2026
ishandhanani
added a commit
to ishandhanani/dynamo
that referenced
this pull request
Nov 6, 2026
Two upstream commits since d2ceb6a, no conflicts, nothing under a router-owned path and no Rust change: - ai-dynamo#18334 fix(recipes): restore Nemotron 3.5 Super VL benchmark defaults. recipes/.../nemotron-3.5-super-vl-120b-a12b/perf (README, perf.yaml). - ai-dynamo#17937 fix(multimodal): keep invalid-audio errors as client errors in batch loading. components/src/dynamo/common/multimodal/audio_loader.py and its test. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
devivasudevan
pushed a commit
to devivasudevan/dynamo
that referenced
this pull request
Nov 7, 2026
…namo#18334) Signed-off-by: milesial <milesial@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The Nemotron 3.5 Super VL benchmark Job leaves four shared parameters empty, so users cannot find their values in the recipe. Restore the prior Job defaults and document their units.
Key Changes
BENCHMARK_DURATION=3600,WARMUP_GRACE_PERIOD=1800,REQUEST_TIMEOUT_SECONDS=7200, andMAX_CONTEXT_LENGTH=1048576.Validation
Parsed both YAML documents and compared the restored values with the prior benchmark Job. The embedded shell script passes
bash -n. These are recovered Job defaults, not a new reproduction of the published performance results.Issues and Ongoing Work
Closes #18333.
No duplicate fix found. #14753 addresses AIPerf version pins in other recipes.
Pull Request Checklist
/pr-checklistskill.Summary by CodeRabbit
ENDPOINT,CONCURRENCY,ARTIFACT_DIR, andCACHE_SALTas the values to configure inperf.yaml; the other settings use job defaults.