Repository navigation
fix(router): [release-only 1.7.0] read the session-affinity entry limit from the parser environment - #18341
Merged
dagil-nvidia merged 1 commit intoNov 6, 2026
Conversation
…vironment On release/1.7.0, --router-session-affinity-max-entries was registered without env=self.env, so the frontend parser read DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIES from os.environ. That fails test_no_registered_env_var_is_read_from_os_environ. The release pick of #18240 (#18266) landed before this branch had the env= argument. The later pick of #17483 (#18005) added it to the other router flags, and added the test, but missed this flag. main already passes env=self.env here, and router_args.py now matches main. Refs DIS-3354 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Andrew Paprotsky <apaprotskyi@nvidia.com>
steved
approved these changes
Nov 6, 2026
Contributor
✅ Dynamo PR CI passed — run 42281943792 (attempt 2) on
|
dagil-nvidia
deleted the
apaprotskyi/release-1.7.0-session-affinity-env
branch
November 6, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-only fix for
release/1.7.0. On this branch,--router-session-affinity-max-entrieswas registered withoutenv=self.env, so the frontend parser readDYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIESfromos.environ. That failstest_no_registered_env_var_is_read_from_os_environ. Because the test fails in the first stage of thedynamo-runtimesequential jobs, every release PR that runs those jobs goes red, and their later pytest stages never run.env=argument. The later pick of feat(planner): live retune from recorded traces through DGDR v1beta2 #17483 (feat(planner): live retune from recorded traces through DGDR v1beta2 (#17483) #18005) added that argument to the other router flags, and added the test, but missed this flag.env=self.env.router_args.pynow matchesmain, which already has this line, so there is nothing to change onmain.Validation
git diff origin/main -- components/src/dynamo/common/configuration/groups/router_args.pyis empty.dynamo._core). This PR'sdynamo-runtimesequential jobs run it.Refs DIS-3354
🤖 Generated with Claude Code