Skip to content

fix(router): [release-only 1.7.0] read the session-affinity entry limit from the parser environment - #18341

Merged
dagil-nvidia merged 1 commit into
release/1.7.0from
apaprotskyi/release-1.7.0-session-affinity-env
Nov 6, 2026
Merged

dagil-nvidia merged 1 commit into
release/1.7.0from
apaprotskyi/release-1.7.0-session-affinity-env

Conversation

@andrewpaprotsky

Copy link
Copy Markdown
Contributor

Summary

Release-only fix for release/1.7.0. On this branch, --router-session-affinity-max-entries was registered without env=self.env, so the frontend parser read DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIES from os.environ. That fails test_no_registered_env_var_is_read_from_os_environ. Because the test fails in the first stage of the dynamo-runtime sequential jobs, every release PR that runs those jobs goes red, and their later pytest stages never run.

Validation

  • git diff origin/main -- components/src/dynamo/common/configuration/groups/router_args.py is empty.
  • Not run locally: the test imports the Rust bindings (dynamo._core). This PR's dynamo-runtime sequential jobs run it.

Refs DIS-3354

🤖 Generated with Claude Code

…vironment

On release/1.7.0, --router-session-affinity-max-entries was registered
without env=self.env, so the frontend parser read
DYN_ROUTER_SESSION_AFFINITY_MAX_ENTRIES from os.environ. That fails
test_no_registered_env_var_is_read_from_os_environ.

The release pick of #18240 (#18266) landed before this branch had the
env= argument. The later pick of #17483 (#18005) added it to the other
router flags, and added the test, but missed this flag. main already
passes env=self.env here, and router_args.py now matches main.

Refs DIS-3354

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Andrew Paprotsky <apaprotskyi@nvidia.com>
@devin-ai-integration

devin-ai-integration Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 42281943792 (attempt 2) on 781368f00b

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 42281943792. Updated on every full-CI run of this PR.

@dagil-nvidia
dagil-nvidia merged commit 05e72da into release/1.7.0 Nov 6, 2026
190 of 196 checks passed
@dagil-nvidia
dagil-nvidia deleted the apaprotskyi/release-1.7.0-session-affinity-env branch November 6, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants