Repository navigation
build(container): [cherry-pick 1.7.0] bump EFA installer to 1.51.0, Mooncake 0.3.14, and NIXL refs (#18003) - #18348
Conversation
…ooncake 0.3.14, and NIXL refs (#18003) Signed-off-by: Dan Gil <dagil@nvidia.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| nixl_ucx_ref: v1.23.0-rc1 | ||
| vllm_omni_ref: "v0.32.0rc1" | ||
| nixl_ref: v1.4.1 | ||
| nixl_ref: v1.5.0 |
There was a problem hiding this comment.
🟡 vLLM EFA misses the NIXL upgrade
When the upstream image carries older NIXL, changing nixl_ref leaves vLLM EFA on that version. The CUDA runtime extracts NIXL from upstream instead of the newly built wheel.
Learn more
The framework-level NIXL ref sets NIXL_REF for both wheel construction and runtime stages through the argument template. wheel_builder builds NIXL at that ref, but the CUDA vLLM runtime extracts its libraries from the upstream Python wheel. The AWS extension only copies builder NIXL for TensorRT-LLM. Thus the new value does not control the shipped vLLM CUDA/EFA NIXL version; any version difference between upstream and 1.5.0 remains in the image.
Example: If the pinned upstream vLLM image bundles NIXL 1.4.1, setting nixl_ref: v1.5.0 builds a 1.5.0 SDK but the published vLLM EFA image still loads 1.4.1 from its upstream wheel.
Recommended fix: Install the matching nixl and nixl-cu13 wheels in the CUDA runtime or explicitly overlay the builder's libraries and Python bindings there. Verify the effective Python package version and loaded libnixl.so in the final AWS image.
Was this helpful? React with 👍 or 👎 to provide feedback.
| # Per-arch baseline stem (re-captured against tensorrt-llm/release, both arches). | ||
| baseline_sbom: release@93a3eaf1 | ||
| nixl_ref: v1.3.1 | ||
| nixl_ref: v1.5.2 |
There was a problem hiding this comment.
🔍 TensorRT-LLM pin also affects non-EFA images
nixl_ref upgrades Python packages in standard TensorRT-LLM images while LD_PRELOAD retains upstream libnixl.so. Check compatibility of the new bindings with that library.
Was this helpful? React with 👍 or 👎 to provide feedback.
✅ Dynamo PR CI passed — run 42306794534 (attempt 1) on
|
Overview
Cherry-pick of #18003 into
release/1.7.0. Refs DGH-2454.Bumps the AWS EFA installer to 1.51.0, the Mooncake transfer engine floor to 0.3.14, and the per-framework NIXL refs for the EFA images.
Pick Notes
mainas ef8d3b1. The pick matches that commit line for line (5 files, +14 -14).Validation
release/1.7.0at 9abd2ef (RC2).