Repository navigation
ci: move Planner tests out of runtime CPU lanes - #18351
Conversation
Signed-off-by: hongkuanz <hongkuanz@nvidia.com>
|
No actionable comments were generated in the recent review. WalkthroughThe change updates planner and core test markers, adjusts CPU-only test selection in the Dynamo pipeline, and adds a nightly planner test job that gates release and is a dependency of Slack notification. ChangesPlanner CPU testing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk:
|
Signed-off-by: hongkuanz <hongkuanz@nvidia.com>
✅ Dynamo PR CI passed — run 42309505310 (attempt 1) on
|
- 84c3ecd fix(mocker): admit sequential disagg decode with transferred prompt KV (ai-dynamo#18384): one file, lib/llm/src/mocker.rs (+56), auto-merged and taken whole: the decode-side branch that submits through LiveEngine::submit_decode when the request carries a prefill_result, plus the test sequential_decode_starts_from_transferred_prompt_kv. The mocker frontend stays in lib/llm; the handoff path it calls stays in lib/mocker. No router-owned path. - 227025e fix(bindings): keep mm-routing opt-in for the default wheel (ai-dynamo#18199): three manifests. lib/bindings/python/Cargo.toml auto-merged (the mm-routing feature now also enables the sglang and trtllm sidecars' mm-routing; both sidecar dependencies gain default-features = false; the split's router dependency list and feature wiring untouched). lib/sidecar/sglang/Cargo.toml auto-merged (upstream's [features] block with default = ["mm-routing"]; the split's dynamo-kv-events dev-dependency stays). lib/sidecar/trtllm/Cargo.toml conflicted on the [dependencies] hunk: resolved as upstream's [features] block and the bare dynamo-llm = { path = "../../llm", default-features = false } line with the SBOM comment dropped as upstream did, keeping the split's dynamo-kv-events = { workspace = true } in place of the pre-split dynamo-kv-router edge; the dev-dependencies dynamo-kv-hashing and dynamo-router-protocol are unchanged. No lockfile change; all four lockfiles pass --locked. The default bindings wheel resolves no dynamo-llm/mm-routing edge and --features mm-routing resolves one, as upstream intends. - f4a437e ci: move Planner tests out of runtime CPU lanes (ai-dynamo#18351): ten files, auto-merged and taken whole: .github/workflows/dynamo-pipeline.yml and nightly-ci.yml (the new planner-test lane, the "(not planner or core)" marker filter on the runtime CPU lanes), container/Dockerfile.test (COPY of the replay and router retune tests), and pytest.mark.planner or pytest.mark.core added to seven Python test files under components/src/dynamo/planner/tests/unit, lib/bindings/python/tests/replay and tests/dependencies. No Rust, no Cargo.toml, no router-owned path. - f42e5b1 fix(frontend): keep declared Responses tools in the prompt when allowed_tools restricts calls (ai-dynamo#18429): three lib/llm files, auto-merged and taken whole: lib/llm/src/protocols/openai/responses/template_tools.rs (the renderer reads the full declared tool catalog through template_catalog(); allowed_tools narrows only the backend view and call enforcement), its tests/tool_adaptation.rs, and the new integration test lib/llm/tests/responses_http_replay.rs. No router-owned path, no Cargo.toml. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Overview
Planner-family CPU tests also run in the generic Dynamo runtime lanes, duplicating coverage and pushing the arm64 parallel lane against its 30-minute timeout. Run these tests in the existing Planner jobs and add equivalent nightly coverage, while retaining runtime bindings and dependency checks.
Key Changes
plannertests unless also markedcore; the three replay bindings modules and AISimulate dependency contracts retain runtime coverage.Validation
test_advisory_mode.py,test_aic_interpolation.py, andtest_perf_metrics_priority.pypassed under the Planner selector with the pinned AISimulate wheel.Full runtime bindings collection could not complete locally: the shared venv's older
_coreextension lacksAisPerfConfig. No bindings rebuild, Planner image build, full relocated suite, or GitHub Actions run was performed locally; these remain CI validation boundaries. Workflow lint passed with existing unregistered runner-label warnings filtered out.Issues and Ongoing Work
Pull Request Checklist
/pr-checklistskill.Summary by CodeRabbit