Skip to content

fix(trtllm): [cherry-pick 1.7.0] return 400 for guided decoding grammar rejections (#18311) - #18356

Merged
nv-nmailhot merged 1 commit into
ai-dynamo:release/1.7.0from
glamr-agent:cherry-pick/18311-to-release-1.7.0
Nov 9, 2026
Merged

nv-nmailhot merged 1 commit into
ai-dynamo:release/1.7.0from
glamr-agent:cherry-pick/18311-to-release-1.7.0

Conversation

@glamr-agent

Copy link
Copy Markdown
Collaborator

Overview

Cherry-pick of #18311 (fix(trtllm): return 400 for guided decoding grammar rejections) to release/1.7.0. Same change as #18311, merged on main on 2026-11-07; this PR adds nothing.

Key Changes

One commit: git cherry-pick -x --signoff 20a9321cf16eb11e95fd12194c3033c210f7b2be. Applied cleanly.

Validation

Release-branch CI is requested below. If it fails, reply in the GLAMR thread on DYN-5470 and GLAMR will look. Close this PR if the pick is not wanted.

Issues and Ongoing Work

Refs DYN-5470

…namo#18311)

Signed-off-by: svc-glamr@nvidia.com <svc-glamr@nvidia.com>
Signed-off-by: GLAMR <svc-glamr@nvidia.com>
Co-authored-by: Indrajit Bhosale <iamindrajitb@gmail.com>
(cherry picked from commit 20a9321)
Signed-off-by: GLAMR <svc-glamr@nvidia.com>
@glamr-agent
glamr-agent requested a review from a team as a code owner November 7, 2026 03:17
@glamr-agent

Copy link
Copy Markdown
Collaborator Author

@dynamo-ops please run full CI for 15a287a

@copy-pr-bot

copy-pr-bot Bot commented Nov 7, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@glamr-agent
glamr-agent temporarily deployed to external_collaborator November 7, 2026 03:17 — with GitHub Actions Inactive
@glamr-agent
glamr-agent temporarily deployed to external_collaborator November 7, 2026 03:17 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

👋 Hi glamr-agent! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions Bot added fix external-contribution Pull request is from an external contributor backend::trtllm Relates to the trtllm backend labels Nov 7, 2026
@dynamo-ops

Copy link
Copy Markdown
Contributor

/ok to test 15a287a

@devin-ai-integration

Copy link
Copy Markdown
Contributor

✅ Dynamo PR CI passed — run 42333378579 (attempt 1) on 15a287a58a

Gate checks: ✅ backend-status-check · ✅ deploy-status-check · ✅ dynamo-status-check

Posted automatically by Devin for run 42333378579. Updated on every full-CI run of this PR.

@nv-nmailhot
nv-nmailhot merged commit 03afd96 into ai-dynamo:release/1.7.0 Nov 9, 2026
111 checks passed

This branch was previously deployed

1 inactive deployment
external_collaborator — 15a287a5 Deployed Nov 7, 2026 by glamr-agent via ok-to-test #47955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend::trtllm Relates to the trtllm backend external-contribution Pull request is from an external contributor fix size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants