Repository navigation
docs: fix Snapshot doc links broken by its docs restructure - #18490
Conversation
ai-dynamo/snapshot#786 removed Snapshot's docs/operations/ directory, so three links on the Restore Workers with Dynamo Snapshot page return 404 and the Docs link check fails on every pull request. Point them at the pages that replaced them: storage.md was renamed to operate/configure-storage.md, the install page was folded into get-started/installation.md, and the troubleshooting page was split, so the failed-restore link now goes to troubleshooting/restores.md. Signed-off-by: Fang Han <fangh@nvidia.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe Snapshot documentation page now links to the current storage, installation, and troubleshooting pages. ChangesSnapshot documentation links
Estimated code review effort: 1 (Trivial) | ~3 minutes Severity of issue fixed: Medium Merge Risk:
|
Apply the three-link correction from ai-dynamo#18490. Refs ai-dynamo#18489. Original-commit: 58703a3 Co-authored-by: Fang Han <fangh@nvidia.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Kanishk Singh <130019754+kanishksingh01@users.noreply.github.com>
|
/ok to test 58703a3 |
Absorbs 2 upstream commits (3e1a20a, 72ca671). One conflict: lib/llm/src/kv_router/routing_host/hosted.rs, where upstream removed select_lora_target (it becomes LegacyLoraPolicy::select in the new lib/llm/src/lora_routing.rs) and the stack had changed one line inside it (.map_err(KvSchedulerError::from) on the hosted picker call, because dynamo_worker_selection's HostedWorkerPicker::select returns SelectionFailure where upstream's returns KvSchedulerError). Took upstream's removal; the map_err moves with the code into lora_routing.rs, matching the two remaining lib/llm picker call sites. - ai-dynamo#17889 refactor(router) generic candidate policy hooks: lib/llm only. routing_policy.rs gains the crate-private HostedCandidatePolicy, KvAdmissionPolicy, CandidateSelection and AttemptLease; lora_routing.rs (new) holds LegacyLoraPolicy (hosted) and LegacyLoraAdmission (KV) with the load lease and two unit tests; RoutingHost's lora field becomes candidate_policy and RequestGuard's lora load guard becomes _attempt_lease; KvRouter's availability callback delegates to the admission policy; hosted_request becomes pub(crate) and is re-exported with hosted_picker from kv_router.rs; the routing_host test module gains failing and unfinished dispatch cases. The two new files import SchedulingRequest, ScheduleMode and KvSchedulerError from dynamo_scheduler::host, HostedWorkerPicker from dynamo_worker_selection::host and WorkerWithDpRank from dynamo_router_protocol::worker instead of the pre-split dynamo_kv_router paths. Both traits take lib/llm's PreprocessedRequest and RuntimeConfigWatch and stay private to lib/llm; no router crate, plugin surface or prelude change. - ai-dynamo#18490 docs: fix Snapshot doc links broken by its docs restructure: one docs page; auto-merged. No router-owned path changed; no [features] table or Dynamo path-crate dependency edge changed. Signed-off-by: Ishan Dhanani <ishandhanani@gmail.com>
Overview
ai-dynamo/snapshot#786 restructured Snapshot's docs on 2026-11-09 and removed its
docs/operations/directory. Three links on the Restore Workers with Dynamo Snapshot page point into it, so theDocs link check(lychee) fails on every pull request and onmain. This PR points them at the pages that replaced them.Key Changes
This is a docs-only change: three links on one page, with 0 core-logic lines.
model-loading/snapshot.mdx: retarget the three links. The link text is unchanged.docs/operations/storage.mddocs/operate/configure-storage.mddocs/operations/install.mddocs/get-started/installation.mddocs/operations/troubleshooting.mddocs/troubleshooting/restores.mdValidation
The status codes come from unauthenticated requests, as lychee sends them. The page's other two Snapshot links are unchanged and return 200: the README's
#prerequisitesheading still exists, and ai-dynamo/snapshot#456 resolves.On this PR, the
Docs link checkpasses: lychee reports 0 errors across 9,928 links (job).On
main, lychee reports onlystorage.mdandtroubleshooting.md.install.mdis also 404, but the workflow most likely still holds an earlier result for it in.lycheecache. These three lines are the only links intodocs/operations/in the repository, and the page has nozh-CNtranslation.Issues and Ongoing Work
install.md. This PR lands only the link fix, so the check passes for every open PR sooner. Its targets match ci: add Cloud Agent source development environment #18438's, so both branches merge cleanly after it.Pull Request Checklist
/pr-checklistskill.🤖 Generated with Claude Code
Summary by CodeRabbit