Repository navigation
fix: manylinux tag in ai-dynamo-vllm wheel - #884
Merged
Merged
Conversation
nv-anants
marked this pull request as ready for review
April 29, 2025 13:16
nv-anants
requested review from
alec-flowers,
ishandhanani,
nnshah1,
ptarasiewiczNV,
rmccorm4 and
tanmayv25
as code owners
April 29, 2025 13:16
rmccorm4
approved these changes
Apr 29, 2025
rmccorm4
reviewed
Apr 29, 2025
| sed -i "s/^Version: ${VLLM_REF}/Version: ${VLLM_PATCHED_PACKAGE_VERSION}/g" ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/METADATA && \ | ||
| # Update wheel tag from linux_${ARCH_ALT} to manylinux1_${ARCH_ALT} in WHEEL file | ||
| sed -i 's/Tag: cp38-abi3-linux_${ARCH_ALT}/Tag: cp38-abi3-manylinux1_${ARCH_ALT}/g' ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/WHEEL && \ | ||
| sed -i "s/Tag: cp38-abi3-linux_${ARCH_ALT}/Tag: cp38-abi3-manylinux1_${ARCH_ALT}/g" ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/WHEEL && \ |
Contributor
There was a problem hiding this comment.
Thanks for fixing this!
This going uncaught in my PR probably means we need to improve the x86 CI test to do more validation on wheel or pip install
Member
Author
There was a problem hiding this comment.
+1 on more testing.
There might be other ways to validate this, but I think pip install allows linux tags and would not throw error in this case.
saturley-hall
pushed a commit
that referenced
this pull request
Apr 29, 2025
yao531441
pushed a commit
to yao531441/dynamo
that referenced
this pull request
May 13, 2026
tmonty12
added a commit
that referenced
this pull request
Nov 13, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in the chart and the operator go.mod, and its own compatibility matrix says 1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15 sentences in multinode-orchestration.md came from the rollout-budget change (#15725) and from #17216; neither feature exists in 1.6.x. GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1 (grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884) do not touch the index variables. The alpha.15 recommendations for Coherent updates and for 1.7.x rollout budgets are unchanged. Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12
added a commit
that referenced
this pull request
Nov 13, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in the chart and the operator go.mod, and its own compatibility matrix says 1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15 sentences in multinode-orchestration.md came from the rollout-budget change (#15725) and from #17216; neither feature exists in 1.6.x. GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1 (grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884) do not touch the index variables. The alpha.15 recommendations for Coherent updates and for 1.7.x rollout budgets are unchanged. Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12
added a commit
that referenced
this pull request
Nov 16, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in the chart and the operator go.mod, and its own compatibility matrix says 1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15 sentences in multinode-orchestration.md came from the rollout-budget change (#15725) and from #17216; neither feature exists in 1.6.x. GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1 (grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884) do not touch the index variables. The alpha.15 recommendations for Coherent updates and for 1.7.x rollout budgets are unchanged. Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12
added a commit
that referenced
this pull request
Nov 16, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in the chart and the operator go.mod, and its own compatibility matrix says 1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15 sentences in multinode-orchestration.md came from the rollout-budget change (#15725) and from #17216; neither feature exists in 1.6.x. GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1 (grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884) do not touch the index variables. The alpha.15 recommendations for Coherent updates and for 1.7.x rollout budgets are unchanged. Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: