Skip to content

fix: manylinux tag in ai-dynamo-vllm wheel - #884

Merged
nv-anants merged 1 commit into
mainfrom
anants/fix-vllm-whl-tag
Apr 29, 2025
Merged

nv-anants merged 1 commit into
mainfrom
anants/fix-vllm-whl-tag

Conversation

@nv-anants

Copy link
Copy Markdown
Member

Overview:

  • use double quotes to reference variable value in sed commands

@nv-anants
nv-anants merged commit 97bf818 into main Apr 29, 2025
@nv-anants
nv-anants deleted the anants/fix-vllm-whl-tag branch April 29, 2025 14:35
Comment thread container/Dockerfile.vllm
sed -i "s/^Version: ${VLLM_REF}/Version: ${VLLM_PATCHED_PACKAGE_VERSION}/g" ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/METADATA && \
# Update wheel tag from linux_${ARCH_ALT} to manylinux1_${ARCH_ALT} in WHEEL file
sed -i 's/Tag: cp38-abi3-linux_${ARCH_ALT}/Tag: cp38-abi3-manylinux1_${ARCH_ALT}/g' ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/WHEEL && \
sed -i "s/Tag: cp38-abi3-linux_${ARCH_ALT}/Tag: cp38-abi3-manylinux1_${ARCH_ALT}/g" ${VLLM_PATCHED_PACKAGE_NAME}-${VLLM_PATCHED_PACKAGE_VERSION}.dist-info/WHEEL && \

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

This going uncaught in my PR probably means we need to improve the x86 CI test to do more validation on wheel or pip install

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on more testing.

There might be other ways to validate this, but I think pip install allows linux tags and would not throw error in this case.

yao531441 pushed a commit to yao531441/dynamo that referenced this pull request May 13, 2026
tmonty12 added a commit that referenced this pull request Nov 13, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in
the chart and the operator go.mod, and its own compatibility matrix says
1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15
sentences in multinode-orchestration.md came from the rollout-budget
change (#15725) and from #17216; neither feature exists in 1.6.x.

GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1
(grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884)
do not touch the index variables. The alpha.15 recommendations for Coherent
updates and for 1.7.x rollout budgets are unchanged.

Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12 added a commit that referenced this pull request Nov 13, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in
the chart and the operator go.mod, and its own compatibility matrix says
1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15
sentences in multinode-orchestration.md came from the rollout-budget
change (#15725) and from #17216; neither feature exists in 1.6.x.

GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1
(grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884)
do not touch the index variables. The alpha.15 recommendations for Coherent
updates and for 1.7.x rollout budgets are unchanged.

Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12 added a commit that referenced this pull request Nov 16, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in
the chart and the operator go.mod, and its own compatibility matrix says
1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15
sentences in multinode-orchestration.md came from the rollout-budget
change (#15725) and from #17216; neither feature exists in 1.6.x.

GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1
(grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884)
do not touch the index variables. The alpha.15 recommendations for Coherent
updates and for 1.7.x rollout budgets are unchanged.

Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>
tmonty12 added a commit that referenced this pull request Nov 16, 2026
Every 1.6.x release (1.6.0, 1.6.1, 1.6.2) bundles Grove v0.1.0-alpha.14 in
the chart and the operator go.mod, and its own compatibility matrix says
1.6.x requires alpha.14 or later. The alpha.15 row and the two alpha.15
sentences in multinode-orchestration.md came from the rollout-budget
change (#15725) and from #17216; neither feature exists in 1.6.x.

GROVE_PCSG_POD_INDEX itself is defined by Grove from v0.1.0-alpha.14-rc1
(grove #755); the changes between alpha.14 and alpha.15 (#848, #880, #884)
do not touch the index variables. The alpha.15 recommendations for Coherent
updates and for 1.7.x rollout budgets are unchanged.

Signed-off-by: Thomas Montfort <tjmontfort12@gmail.com>

This branch was previously deployed

1 inactive deployment
GITLAB — 9d9c0124 Deployed Apr 29, 2025 by copy-pr-bot[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants