Repository navigation
Conversation
…down Modeled on ai-dynamo/dynamo PR ai-dynamo#8342. Adds FATAL_KV_TRANSFER_ERROR_PATTERNS and extends the except RequestError branch to also restart the worker on TRT-LLM poisoned-cache-transfer-buffer errors.
Contributor
|
👋 Hi yifjiang! Thank you for contributing to ai-dynamo/dynamo. Just a reminder: The 🚀 |
Contributor
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Contributor
|
This PR has been closed due to inactivity. If you believe this PR is still relevant, please feel free to reopen it with additional context or information. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When TRT-LLM raises a
RequestErrorfor an unrecoverable KV cache transfer failure (poisoned NIXL/UCX buffer pool), the dynamo TRT-LLM handler currently swallows it as a per-request warning and keeps serving with a corrupted buffer pool. This results in a wedge where every subsequent generation request getsCannot assign cache transfer buffer kind=kvand clients see HTTP 500.This PR extends the existing
FATAL_CUDA_ERROR_PATTERNSdesign (#8342) to also escalate poisoned-KV-cache-transfer-buffer errors. On a match, the worker logs the fatal, emits the error chunk, and calls_initiate_shutdown()so k8s/docker can restart the container.Validation
Validated against the 1P/1D production-like canary reproducer that wedges with current main:
round=0 decode_poison=1 decode_cannot=0 decode_restarts=1(vs unpatched:decode_restarts=0with repeatedCannot assign cache transfer buffer)docs/disagg-pr13713-v9-poison-restart-verdict-2026-05-12.md(in dynamo-gb200-test repo)Patterns
The regex matches both the C++ log strings (kept for backward compat) and the Python wrapper that surfaces to the
RequestError:baseTransBuffer.cpp:Cannot assign cache transfer buffer.*poisoned,previous transfer left the buffer pool poisoned,Poisoned .* cache transfer buffer,process must restart before these memory rangespy_executor.py:Error in kv cache transfer for (context|generation) requests(matches both pre-PR-13713-v10 plain wrappers and post-v10 poison-aware wrappers since they share the prefix)Test plan
decode_restarts=1on first poison hit (was 0)🤖 Generated with Claude Code