Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
=======================================
Coverage 76.33% 76.33%
=======================================
Files 73 73
Lines 20293 20293
=======================================
Hits 15490 15490
Misses 4803 4803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mitigate rustc query-depth overflow on Rust 1.94+ by splitting large Query/Mutation MergedObject groups. Preserve existing GraphQL schema and response behavior.
a3c2626 to
2f4e7f3
Compare
kimhanbeom
approved these changes
Mar 9, 2026
sophie-cluml
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR refactors the shape of the GraphQL root objects to reduce rustc query-depth pressure that can cause "queries overflow the depth limit" build failures on Rust 1.94+. The overflow is reproducible in our build/test on 1.94+ and is likely caused by recent layout-path changes that add an extra wrapping layer (e.g. ManuallyDrop -> MaybeDangling) which increases type-layout query depth in large merged GraphQL root types.
What changed
Files changed
Why this fixes the issue
Splitting large merged groups reduces the depth of type-layout queries produced by the derive/merge machinery for complex async/type-heavy GraphQL root types. This lowers the probability of hitting rustc's query-depth limit, especially on Rust 1.94+ where layout paths increased in depth.
Verification
Notes
References
MergedObjectgroups to reduce rustc query-depth overflow on Rust 1.94+ #801Closes #801