-
Notifications
You must be signed in to change notification settings - Fork 1
Migrate power control handling to roxyd (issue #613) #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+734
−19
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e33d09a
Update CHANGELOG.md and 2 other files
octoaide[bot] 77c9d84
Resolve merge conflict in roxyd power tests
octoaide[bot] 1078824
Update power handling to review-protocol 0.19.0
octoaide[bot] e25e3ba
Rename executor to backend and simplify dispatch
octoaide[bot] 33bfccd
Migrate power handling to module handler
octoaide[bot] 94a79a6
Improve power handler and control test stability
octoaide[bot] bd82a67
Unify wait_for_mock_count for power tests
octoaide[bot] f51f7d1
Add flat reboot/shutdown tests; clarify CHANGELOG
octoaide[bot] 8ca2ad6
Use Notify for node_power test synchronization
octoaide[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence can read as if legacy flat
reboot/shutdownalso stop returning a protocol response. As far as I understand, flat requests delegate to the same immediate power backend, but still keep the legacy()response path. Could we clarify that distinction here?